Skip to content

Commit fcc4d40

Browse files
Declare readonly properties
1 parent 681d8af commit fcc4d40

28 files changed

+55
-55
lines changed

src/CodeCoverage.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@
3939
final class CodeCoverage
4040
{
4141
private const UNCOVERED_FILES = 'UNCOVERED_FILES';
42-
private Driver $driver;
43-
private Filter $filter;
44-
private Wizard $wizard;
42+
private readonly Driver $driver;
43+
private readonly Filter $filter;
44+
private readonly Wizard $wizard;
4545
private bool $checkForUnintentionallyCoveredCode = false;
4646
private bool $includeUncoveredFiles = true;
4747
private bool $ignoreDeprecatedCode = false;

src/Driver/PcovDriver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*/
2727
final class PcovDriver extends Driver
2828
{
29-
private Filter $filter;
29+
private readonly Filter $filter;
3030

3131
/**
3232
* @throws PcovNotAvailableException

src/Exception/UnintentionallyCoveredCodeException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ final class UnintentionallyCoveredCodeException extends RuntimeException impleme
1616
/**
1717
* @var list<string>
1818
*/
19-
private array $unintentionallyCoveredUnits;
19+
private readonly array $unintentionallyCoveredUnits;
2020

2121
/**
2222
* @param list<string> $unintentionallyCoveredUnits

src/Node/AbstractNode.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222
*/
2323
abstract class AbstractNode implements Countable
2424
{
25-
private string $name;
25+
private readonly string $name;
2626
private string $pathAsString;
2727
private array $pathAsArray;
28-
private ?AbstractNode $parent;
28+
private readonly ?AbstractNode $parent;
2929
private string $id;
3030

3131
public function __construct(string $name, self $parent = null)

src/Node/Builder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
*/
3131
final class Builder
3232
{
33-
private FileAnalyser $analyser;
33+
private readonly FileAnalyser $analyser;
3434

3535
public function __construct(FileAnalyser $analyser)
3636
{

src/Node/CrapIndex.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
*/
1717
final class CrapIndex
1818
{
19-
private int $cyclomaticComplexity;
20-
private float $codeCoverage;
19+
private readonly int $cyclomaticComplexity;
20+
private readonly float $codeCoverage;
2121

2222
public function __construct(int $cyclomaticComplexity, float $codeCoverage)
2323
{

src/Node/File.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ final class File extends AbstractNode
2020
{
2121
private array $lineCoverageData;
2222
private array $functionCoverageData;
23-
private array $testData;
23+
private readonly array $testData;
2424
private int $numExecutableLines = 0;
2525
private int $numExecutedLines = 0;
2626
private int $numExecutableBranches = 0;
@@ -34,7 +34,7 @@ final class File extends AbstractNode
3434
/**
3535
* @psalm-return array{linesOfCode: int, commentLinesOfCode: int, nonCommentLinesOfCode: int}
3636
*/
37-
private array $linesOfCode;
37+
private readonly array $linesOfCode;
3838
private ?int $numClasses = null;
3939
private int $numTestedClasses = 0;
4040
private ?int $numTraits = null;

src/Node/Iterator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ final class Iterator implements RecursiveIterator
2222
/**
2323
* @var list<AbstractNode>
2424
*/
25-
private array $nodes;
25+
private readonly array $nodes;
2626

2727
public function __construct(Directory $node)
2828
{

src/Report/Crap4j.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
final class Crap4j
2525
{
26-
private int $threshold;
26+
private readonly int $threshold;
2727

2828
public function __construct(int $threshold = 30)
2929
{

src/Report/Html/Colors.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414
*/
1515
final class Colors
1616
{
17-
private string $successLow;
18-
private string $successMedium;
19-
private string $successHigh;
20-
private string $warning;
21-
private string $danger;
17+
private readonly string $successLow;
18+
private readonly string $successMedium;
19+
private readonly string $successHigh;
20+
private readonly string $warning;
21+
private readonly string $danger;
2222

2323
public static function default(): self
2424
{

0 commit comments

Comments
 (0)