Checkstyle: Remove exceptions for JUnit 4 annotations

Checkstyle contains exceptions to allow certain exceptions in coding
style for JUnit 4 tests. For example, Checkstyle allows declaration of
a public variable if it is preceded by a Rule tag so as to ensure
correct variable assignment by JUnit 4.

After migrating all tests to JUnit 5, we no longer need these
exceptions for annotations specific to JUnit 4. Hence, we can remove
these annotations to tighten our strictness on coding style.

Hence, let's remove exceptions in checkstyle for JUnit 4 annotations.
Notably, let's remove
* Before/BeforeClass/After/AfterClass tags used to denote functions to
run before/after a test
* Rule/ClassRule tags used to denote rules (now extensions in JUnit 5)

Author: sijie123

config/checkstyle/checkstyle.xml

@@ -229,7 +229,7 @@
     <module name="VisibilityModifier">
       <property name="protectedAllowed" value="true"/>
       <property name="allowPublicFinalFields" value="true"/>
-      <property name="ignoreAnnotationCanonicalNames" value="Rule, ClassRule, RegisterExtension, TempDir"/>
+      <property name="ignoreAnnotationCanonicalNames" value="RegisterExtension, TempDir"/>
     </module>
 
     <!--
@@ -391,7 +391,7 @@
         Single line of code methods are often due to refactor for readability.
       -->
       <property name="minLineCount" value="1"/>
-      <property name="allowedAnnotations" value="Override, Test, Before, BeforeAll, BeforeClass, BeforeEach, After, AfterAll, AfterClass, AfterEach, Subscribe"/>
+      <property name="allowedAnnotations" value="Override, Test, BeforeAll, BeforeEach, AfterAll, AfterEach, Subscribe"/>
       <property name="scope" value="public"/>
       <property name="allowUndeclaredRTE" value="true"/>
       <property name="allowThrowsTagsForSubclasses" value="true"/>
@@ -408,7 +408,7 @@
         We define methods that have more than 3 lines of code as non-trivial.
       -->
       <property name="minLineCount" value="3"/>
-      <property name="allowedAnnotations" value="Override, Test, Before, BeforeAll, BeforeClass, BeforeEach, After, AfterAll, AfterClass, AfterEach, Subscribe"/>
+      <property name="allowedAnnotations" value="Override, Test, BeforeAll, BeforeEach, AfterAll, AfterEach, Subscribe"/>
       <property name="scope" value="private"/>
       <property name="allowUndeclaredRTE" value="true"/>
       <property name="allowThrowsTagsForSubclasses" value="true"/>