replace swingsetTests

[turadg]

What is the Problem Being Solved?

The tests in test/swingsetTests are brittle and made before we had SwingSet RunUtils. Much of what they cover is now covered elsewhere now.

Exos have good coverage of behavior without SwingSet integration.
For SwingSet integration we have @agoric/boot with RunUtils.
We may soon have a way to test RunUtils picking up from a state: #10807

Related:

• Impedence mismatch between swingset-runner and Zoe tests #1194

Description of the Design

Remove swingsetTests that are covered elsewhere.

For what's left, convert to modern tests. They can have their own very light bootstrap config.
TBD whether they live in swingsetTests as a new meaning of the term.

Security Considerations

Scaling Considerations

Test Plan

No tests that rely on a log dump from buildVatController except in SwingSet packages.

Upgrade Considerations

[mhofman]

I'm actually not sure we should do this. I actually have a plan to update the fake liveslots environment to make it easier to built tests with it, in particular upgrade tests of a single vat. Afaik, this is still pretty difficult and costly to do with RunUtils based tests.

Edit: maybe I'm confused as to what "swingsetTests" actually are? Are they different than fake liveslots tests?

[turadg]

Yeah, different than fake liveslots tests. They actually use a vat controller with XS workers, but since we didn't have EV yet they have the behavior within the core-eval and the test is just a golden log.

Happy to have better fake liveslots to make unit testing exos and vats higher fidelity, but this is different.

[mhofman]

Perfect. No concerns then. It sounds like RunUtils test right now are strictly superior and cover the same cases as these legacy swingset tests.