Merge pull request graphql-java#1450 from tinnou/9.x-fix-classCastException-type-condition-input-type

Fix graphql-java#1440 ClassCastException when using a fragment with wrong input type condition and overlapping fields are being merged.

Author: andimarek

src/main/java/graphql/validation/rules/FragmentsOnCompositeType.java

@@ -36,7 +36,7 @@ public void checkFragmentDefinition(FragmentDefinition fragmentDefinition) {
         if (type == null) return;
         if (!(type instanceof GraphQLCompositeType)) {
             String message = "Fragment type condition is invalid, must be on Object/Interface/Union";
-            addError(ValidationErrorType.InlineFragmentTypeConditionInvalid, fragmentDefinition.getSourceLocation(), message);
+            addError(ValidationErrorType.FragmentTypeConditionInvalid, fragmentDefinition.getSourceLocation(), message);
         }
     }
 }

src/main/java/graphql/validation/rules/OverlappingFieldsCanBeMerged.java

@@ -305,14 +305,14 @@ private void collectFieldsForFragmentSpread(Map<String, List<FieldAndType>> fiel
             return;
         }
         visitedFragmentSpreads.add(fragment.getName());
-        GraphQLOutputType graphQLType = (GraphQLOutputType) TypeFromAST.getTypeFromAST(getValidationContext().getSchema(),
+        GraphQLType graphQLType = TypeFromAST.getTypeFromAST(getValidationContext().getSchema(),
                 fragment.getTypeCondition());
         collectFields(fieldMap, fragment.getSelectionSet(), graphQLType, visitedFragmentSpreads);
     }
 
     private void collectFieldsForInlineFragment(Map<String, List<FieldAndType>> fieldMap, Set<String> visitedFragmentSpreads, GraphQLType parentType, InlineFragment inlineFragment) {
         GraphQLType graphQLType = inlineFragment.getTypeCondition() != null
-                ? (GraphQLOutputType) TypeFromAST.getTypeFromAST(getValidationContext().getSchema(), inlineFragment.getTypeCondition())
+                ? TypeFromAST.getTypeFromAST(getValidationContext().getSchema(), inlineFragment.getTypeCondition())
                 : parentType;
         collectFields(fieldMap, inlineFragment.getSelectionSet(), graphQLType, visitedFragmentSpreads);
     }

src/test/groovy/graphql/Issue1440.groovy

@@ -0,0 +1,90 @@
+package graphql
+
+import graphql.validation.ValidationError
+import graphql.validation.ValidationErrorType
+import spock.lang.Specification
+
+class Issue1440 extends Specification {
+
+    def schema = TestUtil.schema("""
+            type Query {
+                nothing: String
+            }
+            
+            type Mutation {
+                updateUDI(input: UDIInput!): UDIOutput
+            }
+            
+            type UDIOutput {
+                device: String
+                version: String
+            }
+            
+            input UDIInput {
+                device: String 
+                version: String
+            }
+        """)
+
+    def graphQL = GraphQL.newGraphQL(schema).build()
+
+
+    def "#1440 when fragment type condition is input type it should return validation error - not classCastException"() {
+        when:
+        def executionInput = ExecutionInput.newExecutionInput()
+                .query('''                    
+                    mutation UpdateUDI($input: UDIInput!) { 
+                        updateUDI(input: $input) { 
+                            ...fragOnInputType 
+                            __typename 
+                        } 
+                    }
+                    
+                    # fragment should only target composite types
+                    fragment fragOnInputType on UDIInput { 
+                        device
+                        version 
+                        __typename 
+                    } 
+                    
+                    ''')
+                .variables([input: [device: 'device', version: 'version'] ])
+                .build()
+
+        def executionResult = graphQL.execute(executionInput)
+
+        then:
+
+        executionResult.data == null
+        executionResult.errors.size() == 1
+        (executionResult.errors[0] as ValidationError).validationErrorType == ValidationErrorType.FragmentTypeConditionInvalid
+    }
+
+    def "#1440 when inline fragment type condition is input type it should return validation error - not classCastException"() {
+        when:
+        def executionInput = ExecutionInput.newExecutionInput()
+                .query('''                    
+                    mutation UpdateUDI($input: UDIInput!) { 
+                        updateUDI(input: $input) { 
+                            # fragment should only target composite types
+                            ... on UDIInput { 
+                                device
+                                version 
+                                __typename 
+                            }  
+                            __typename 
+                        } 
+                    }
+                    ''')
+                .variables([input: [device: 'device', version: 'version'] ])
+                .build()
+
+        def executionResult = graphQL.execute(executionInput)
+
+        then:
+
+        executionResult.data == null
+        executionResult.errors.size() == 1
+        (executionResult.errors[0] as ValidationError).validationErrorType == ValidationErrorType.InlineFragmentTypeConditionInvalid
+    }
+}

src/test/groovy/graphql/validation/rules/FragmentsOnCompositeTypeTest.groovy

@@ -68,7 +68,7 @@ class FragmentsOnCompositeTypeTest extends Specification {
         fragmentsOnCompositeType.checkFragmentDefinition(fragmentDefinition)
 
         then:
-        errorCollector.containsValidationError(ValidationErrorType.InlineFragmentTypeConditionInvalid)
+        errorCollector.containsValidationError(ValidationErrorType.FragmentTypeConditionInvalid)
     }