Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying settings UI #516

Open
adekbadek opened this issue Jul 23, 2021 · 0 comments
Open

Unifying settings UI #516

adekbadek opened this issue Jul 23, 2021 · 0 comments

Comments

@adekbadek
Copy link
Member

Right now, the configuration might happen in four different places:

  • Newspack Plugin - on setup
  • Newspack Plugin - Engagement Wizard
  • this plugin - native settings screen
  • this plugin - when creating a newsletter while ESP settings are not set

This is not optimal, because any changes to the settings screen have to be synchronised among all these UIs. There should really be a single UI for the settings.

This is an opportunity to rethink how the Newspack Plugin interacts with the other plugins. One way to do it may be to use iframes in the Newspack Plugin, which would display the paricular plugin's UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant