Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Custom Auth #306

Open
GaryParr opened this issue Sep 21, 2021 · 11 comments
Open

Support Custom Auth #306

GaryParr opened this issue Sep 21, 2021 · 11 comments
Labels
complexity: hours Issues that need less than 1 hour to be resolved priority: high (P0) High priority scope: auth Issues related to the authentication emulator scope: cli Issues happened a the ./src/cli level status: need design doc The issue needs a detailed design document status: need internal approval The issue need an internal approval from a stakeholder before it gets addressed type: enhancement New feature or request type: RFC This is a request for comment
Milestone

Comments

@GaryParr
Copy link

Is your feature request related to a problem? Please describe.
Can't test or debug custom auth providers

Describe the solution you'd like
Option to bypass mock auth service when using custom auth

Describe alternatives you've considered
Test and debug using deployed app

Additional context
I'm setting up AAD B2C for my SWA and was really hoping I could run locally to see if I got everything working. This may not be a big deal now, but with everyone asking for AAD role support (and even full claim access) local testing of custom providers will become more important in the future.

@manekinekko manekinekko added scope: auth Issues related to the authentication emulator scope: cli Issues happened a the ./src/cli level status: need design doc The issue needs a detailed design document type: enhancement New feature or request type: RFC This is a request for comment labels Sep 27, 2021
@GaryParr
Copy link
Author

With SWA releasing role management functions, custom auth support in development may have just become a bit more important.

@GaryParr
Copy link
Author

Any update on this?

Alternatively, is there any way to locally develop and test custom role management functions? Currently the cli flat our ignores the relevant configuration...

{ "auth": { "rolesSource": "/api/GetRoles", "identityProviders": { // ... } } }

@felpel
Copy link

felpel commented Nov 28, 2021

This is currently a blocker to actually use SWA for real-life production apps.

I tried to have my deployed SWA talk to my localhost STS with the help of ngrok, but this is far from ideal.

May I suggest to opt-out of mocked authorization through a CLI switch or an option within the SWA config?

@AverageCakeSlice
Copy link

AverageCakeSlice commented Jan 15, 2022

I second this. It would be nice to at least have a more robust auth emulator so that we can simulate the response being returned from the custom identity provider. Like @felpel mentioned, having a way to switch the config to use the actual provider rather than the emulator would be fantastic as well.

@simonaco simonaco added the priority: high (P0) High priority label Jan 20, 2022
@manekinekko manekinekko added status: need internal approval The issue need an internal approval from a stakeholder before it gets addressed complexity: hours Issues that need less than 1 hour to be resolved labels Mar 12, 2022
@GaryParr
Copy link
Author

Just checking in to see where this might be at. I've had to step away from my project for a while so I may have missed some change that obviates the need for this feature request. I do see labels were added over 6 months ago, but nothing since.

@GaryParr
Copy link
Author

May I suggest to opt-out of mocked authorization through a CLI switch or an option within the SWA config?

This. A million times this. Please.

@i-love-code
Copy link

+1 for this.

@davide-bergamini-sevenit

+1 for us too. I've seen a branch about this somewhere, is someone still working on this?

@GaryParr
Copy link
Author

GaryParr commented Jan 3, 2024

Just doing my yearly check in to see if there has been any movement on this issue.

@aeromac
Copy link

aeromac commented Oct 11, 2024

This would be very handy, especially for B2C, which I had assumed would have been supported

@GaryParr
Copy link
Author

GaryParr commented Nov 2, 2024

Do we have any kind of status update? I see this was added to a milestone, but haven't seem much about said milestone other than it is two months overdue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: hours Issues that need less than 1 hour to be resolved priority: high (P0) High priority scope: auth Issues related to the authentication emulator scope: cli Issues happened a the ./src/cli level status: need design doc The issue needs a detailed design document status: need internal approval The issue need an internal approval from a stakeholder before it gets addressed type: enhancement New feature or request type: RFC This is a request for comment
Projects
None yet
Development

No branches or pull requests

9 participants