Failing a Lock action causes the game to freeze because no other action is allowed.

[quall3]

** Fly Casual Release Version**
latest

Describe the bug
If a ship is performing a Lock action and can not, or does not choose an object to lock, the game enters a state that does not progress it and does not allow the user to enter any a commands.

To Reproduce
Steps to reproduce the behavior:

1. Perform a lock action with a ship
2. Skip the step where you choose an object OR have no object available to lock at range
3. No input possible into the game, only option left is to abort the game entirely.

Expected behavior
Allow the game state to progress without a ship acquiring a lock when performing a target lcok action

[Baledin]

Just to confirm, there's no error message, it just freezes?

[quall3]

not a freeze, it is just not possible to enter any input, the game does not progress, but you can still move the camera around and select units (that result in the usual reply that this ship is not controlled by player and has not the right initiative)

[quall3]

this is also problematic when taking the "the child" crew upgrade, because the opponent gets the "merciles pursuit" condition on 2 of his ships, which allows to acquire a lock on the attacked ship after attack. the AI doesnt seem to go through with the lock (or does not select the correct ship) and then the game is in the state where no input is possible.

i guess the game does not progress to the next phase after the attempted lock failed.

[Baledin]

This one is tough to replicate. I've seen it happen but trying to force it to happen is nearly impossible, even with The Child equipped. Can you try to narrow down when it happens and I'll continue to investigate.

[quall3]

This one is tough to replicate. I've seen it happen but trying to force it to happen is nearly impossible, even with The Child equipped. Can you try to narrow down when it happens and I'll continue to investigate.

I can 100% replicate it.
if you have the merciless pursuit condition and a lock on the ship with the child, and then attack the ship with the child, the condition wants to trigger, but something goes wrong in the code.

[Baledin]

With the latest .04 update, I set up a simple joust with The Mandalorian + The Child and Luke Skywalker BoY. Luke gets Merciless pursuit. I was able to get shot multiple times and Luke received all expected target locks with no error. I know that I've seen this issue (although it's been quite awhile now) but I've never been able to force it to happen. I did more testing with Han + The Child with the AI having Tapusk and Cad Bane as suggested by @grandpajive in issue #137, no crash. Can you confirm a crash in .04? I'm wondering if this was inadvertently fixed although I don't recall working on any of the tagetlock subsystems.

[quall3]

I play with this squad:

{"name":"New Squadron","description":"","faction":"scumandvillainy","ruleset":"xwa","points":20,"version":"2.13.44","obstacles":[],"pilots":[{"id":"ketsuonyo","ship":"lancerclasspursuitcraft","points":6,"upgrades":{"crew":["4lom"],"title":["shadowcaster"],"talent":["clantraining"],"illicit":["babufrik"]}},{"id":"themandalorian","ship":"st70assaultship","points":7,"upgrades":{"crew":["thechild"],"title":["razorcrest"],"gunner":["greedo"],"talent":["outmaneuver"],"modification":["stealthdevice"]}},{"id":"cadbane","ship":"rogueclassstarfighter","points":4,"upgrades":{"crew":["qira"],"title":["xanadublood"],"cannon":["syncedlasercannons"],"device":["ionbombs"],"talent":["margsablclosure"]}},{"id":"lapin","ship":"modifiedtielnfighter","points":3,"upgrades":{"cannon":["heavylasercannon"],"talent":["margsablclosure"],"modification":["precisionionengines"]}}],"vendor":{"lbn":{"builder":"Launch Bay Next","builder_url":"https://launchbaynext.app","link":"https://launchbaynext.app/print?lbx='New%20Squadron'.20.3.0.1.ll42.218.l8.353r.l13.930r.l1.1033r.l15.378rr.l92.1063.l8.971r.l16.367r.l14.301r.l1.240r.l15.1064rr.l94.1069.l3.674r.l8.387r.l12.649r.l1.846r.l15.1065rr.l56.1062.l3.256r.l14.867r.l1.846rrr.lr","uid":"71bf4144-a396-4614-b5aa-3341aaf8ca5d","tags":[],"ties":0,"wins":0,"losses":0,"created":"2024-09-03T17:32:07.527Z"}}}

Against This squad:

{"name":"New Squadron","description":"","faction":"resistance","ruleset":"xwa","points":20,"version":"2.14.2","obstacles":[],"pilots":[{"id":"redsquadronexpert","ship":"t70xwing","points":4,"upgrades":{"talent":["predator"],"astromech":["r4astromech"],"configuration":["integratedsfoils"]}},{"id":"redsquadronexpert","ship":"t70xwing","points":4,"upgrades":{"talent":["predator"],"astromech":["r4astromech"],"configuration":["integratedsfoils"]}},{"id":"redsquadronexpert","ship":"t70xwing","points":4,"upgrades":{"talent":["predator"],"astromech":["r4astromech"],"configuration":["integratedsfoils"]}},{"id":"redsquadronexpert","ship":"t70xwing","points":4,"upgrades":{"talent":["predator"],"astromech":["r4astromech"],"configuration":["integratedsfoils"]}},{"id":"redsquadronexpert","ship":"t70xwing","points":4,"upgrades":{"talent":["predator"],"astromech":["r4astromech"],"configuration":["integratedsfoils"]}}],"vendor":{"lbn":{"builder":"Launch Bay Next","builder_url":"https://launchbaynext.app","link":"https://launchbaynext.app/print?lbx='New%20Squadron'.20.4.0.1.ll53.425.l10.284r.l18.486r.l1.241rr.l53.425.l10.284r.l18.486r.l1.241rr.l53.425.l10.284r.l18.486r.l1.241rr.l53.425.l10.284r.l18.486r.l1.241rr.l53.425.l10.284r.l18.486r.l1.241rrr.lr","uid":"7aa3ecf5-241d-467f-88cb-4649b4911db6","tags":["ai"],"ties":0,"wins":3,"losses":0,"created":"2024-09-23T19:02:22.711Z"}}}

it breaks the game 10/10 times when the xwing with the cindition shoots the crest with the child on.
i assume the ai gets the chance to lock but chooses to lock another ship than the crest with the child. that causes some conflict and the game diesnt progress with the next step.

[quall3]

With the latest .04 update, I set up a simple joust with The Mandalorian + The Child and Luke Skywalker BoY. Luke gets Merciless pursuit. I was able to get shot multiple times and Luke received all expected target locks with no error. I know that I've seen this issue (although it's been quite awhile now) but I've never been able to force it to happen. I did more testing with Han + The Child with the AI having Tapusk and Cad Bane as suggested by @grandpajive in issue #137, no crash. Can you confirm a crash in .04? I'm wondering if this was inadvertently fixed although I don't recall working on any of the tagetlock subsystems.

there is not an actual crash.
the game is still going on, no error is happening.
it just diesnt progress to ask for the next input in the next step of the current phase the game is in.