Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when combining Moralo Evals ability (in Y666) and Jabba the Hutt #119

Open
Firefox113 opened this issue Jan 6, 2025 · 2 comments
Open
Labels
bug Something isn't working

Comments

@Firefox113
Copy link

Fly Casual Release Version
Which version did the bug occur in?
20241101.03

Online Game Mode
No

Describe the bug
When flying out of the combat zone with Moralo Evils ability an error occures in the following round. The error is happening the moment Jabbas ability (recover 1 charge on an illicit upgrade) is triggered while the Y666 is not yet on the table. The error will not happen if yabbas charges are spend, before leaving the combat field for the first time.

To Reproduce
Steps to reproduce the behavior:
Equip Jabba and try to leave the combat zone with Moralos ability

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
grafik

Platform/Device (be as specific as possible):

  • OS: Windows 11
@Baledin
Copy link
Owner

Baledin commented Feb 23, 2025

I think you're on to something, if Moralo goes to reserve, they aren't removed from the game and so abilities aren't disabled and can continue to trigger. I'll have to look through the Reserve code to ensure that effects don't trigger when not on field of play.

@Baledin Baledin added the bug Something isn't working label Feb 23, 2025
@Baledin
Copy link
Owner

Baledin commented Feb 23, 2025

I've added a method to disable Upgrades for ships that move into reserve except for any Upgrade which allows such reserve move, such as Boba Fett Crew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants