Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of EventEmitter's deprecated methods #94

Open
dmahajan980 opened this issue Oct 1, 2022 · 4 comments
Open

Replace usage of EventEmitter's deprecated methods #94

dmahajan980 opened this issue Oct 1, 2022 · 4 comments
Assignees

Comments

@dmahajan980
Copy link
Contributor

Describe the bug
Running the application in dev mode, the "Sign-up" screen shows warnings related to usage of removeListener method from EventEmitter (see Screenshots below). This occurs because the removeListener method has been deprecated.

To Reproduce
Steps to reproduce the behavior:

  1. Start the application server in dev mode using the command: yarn start
  2. Run the app on a simulator or device.
  3. Once the app loads, go to "Home" tab.
  4. Press "Sign-up" button to go to the sign-up page.
  5. The warnings will show up at the bottom of the screen. Click on them to expand.

Expected behavior
Ideally, there shouldn't be any warnings/errors.

Screenshots

Screenshot 2022-10-01 at 4 35 59 PM

Screenshot 2022-10-01 at 4 27 14 PM

Screenshot 2022-10-01 at 4 29 31 PM

Screenshot 2022-10-01 at 4 29 43 PM

Smartphone (please complete the following information):

  • Device: iPhone 13 Pro Max
  • OS: iOS 15.5
  • Version: 1.0.0
@dmahajan980
Copy link
Contributor Author

dmahajan980 commented Oct 1, 2022

On further inspection, the source of this warning is @react-navigation (see ticket). In our case, the specific package is @react-navigation/bottom-tabs.

As this app is using a slightly outdated version of the React Navigation packages(v5), I guess these could be resolved by upgrading React Navigation to v6. I can try the migration to check if that resolves these warnings.

@BekahHW
Copy link
Owner

BekahHW commented Oct 3, 2022

@dmahajan980 got for it! If you have questions, or an update, let me know.

@BekahHW
Copy link
Owner

BekahHW commented Oct 27, 2022

@dmahajan980 how are things going with this?

@dmahajan980
Copy link
Contributor Author

Hi @BekahHW, unfortunately, I haven't been able to spend much time on this because of an ongoing project in my company. It would be great if someone else can pick this up as I'm not sure if I can work on this anytime soon. Otherwise, happy to fix this myself in the future once things settle down :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants