Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly Inaccurate Error Message #189

Open
Matt-Munns opened this issue Mar 5, 2021 · 1 comment
Open

Possibly Inaccurate Error Message #189

Matt-Munns opened this issue Mar 5, 2021 · 1 comment

Comments

@Matt-Munns
Copy link

except OSError:

This line will raise a PDFInfoNotInstalledError, with the message Unable to get page count. Is poppler installed and in PATH? for any OSError caught in the above try block. I was getting an error somewhere in that try block, but it was not due to pdfinfo not being installed. I actually successfully ran the code from tests.py that indicated that poppler is installed based on the successful calling of pdfinfo -h

I think it would be good to have a more descriptive error message showing the different possibilities that might be causing the OSError. Or at least some error message based on which the user doesn't think that poppler not being installed or on the path is necessarily the root cause.

@Belval
Copy link
Owner

Belval commented Mar 6, 2021

I am never against improving usability and giving the user a better error message. If you can give me a reproducible test case I'll be happy to fix the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants