Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #209

Open
Peterl777 opened this issue Aug 5, 2021 · 1 comment
Open

Add type annotations #209

Peterl777 opened this issue Aug 5, 2021 · 1 comment

Comments

@Peterl777
Copy link

I've just started using pdf2image and am loving it.
I'd like to do a PR to add type PEP 484 type hints / type annotations.
I have a fair bit of experience with type hints and find them very useful.
As it is already marked 3.6+, I don't see there should be any problems with adding hinting.
I'm aware this would create many changed lines; does any have any suggestions or comments about managing this?

@Belval
Copy link
Owner

Belval commented Aug 13, 2021

I would be more than happy to accept a PR that adds type hinting, no need to worry about the number of changed lines, as long as it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants