Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make agtboost model object entirely numerical #56

Open
Blunde1 opened this issue Aug 1, 2022 · 0 comments · May be fixed by #58
Open

Make agtboost model object entirely numerical #56

Blunde1 opened this issue Aug 1, 2022 · 0 comments · May be fixed by #58

Comments

@Blunde1
Copy link
Owner

Blunde1 commented Aug 1, 2022

The agtboost model class contains the type of loss-function as an std::string type attribute. This is problematic (for memory and garbage collection reasons) when working with a model object from the R side. See e.g. the following comment #55 (comment).

The model could and should consist of entirely numerical attributes.
This was referenced Aug 1, 2022
Open
Draft
@Blunde1 Blunde1 linked a pull request Aug 1, 2022 that will close this issue
Entirely numerical agtboost model class #58
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Entirely numerical agtboost model class Blunde1/agtboost
1 participant
@Blunde1