Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change discoverers to return ModCandidates instead of loading vessels themselves. #3

Closed
ChachyDev opened this issue Jul 28, 2021 · 0 comments · Fixed by #4
Closed

Change discoverers to return ModCandidates instead of loading vessels themselves. #3

ChachyDev opened this issue Jul 28, 2021 · 0 comments · Fixed by #4
Assignees
@ChachyDev
Labels
enhancement New feature or request

Comments

@ChachyDev
Copy link
Member

This issue describes the current problem of the discovery system.

Issues

  • The current system is way too reliant on the developer. It expects the developer to register the vessels themselves resulting in copy-pasted code most of the time and cause big problems if one implements vessel registration incorrectly.
@ChachyDev ChachyDev added the enhancement New feature or request label Jul 28, 2021
@ChachyDev ChachyDev self-assigned this Jul 28, 2021
ChachyDev added a commit that referenced this issue Jul 28, 2021
@ChachyDev
Implement the ModCandidate system
0bd4d3e 
Resolve #3 by changing the use of discoverers.
Instead they strive to provide as many candidates as possible. For the candidates to take and verify. If
they deem the given candidate as invalid they'll be taken to the "rejection site" and if valid kept in the candidates list.
@ChachyDev ChachyDev mentioned this issue Jul 28, 2021
Merged
ChachyDev added a commit that referenced this issue Jul 28, 2021
@ChachyDev
Implement the ModCandidate system (#4)
b662dd8 
* Implement the ModCandidate system

Resolve #3 by changing the use of discoverers.
Instead they strive to provide as many candidates as possible. For the candidates to take and verify. If
they deem the given candidate as invalid they'll be taken to the "rejection site" and if valid kept in the candidates list.

* Move copied variables to constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChachyDev ChachyDev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement the ModCandidate system BookMC/book-loader
1 participant
@ChachyDev