You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Attempting to use Step in "Instant" mode when ViaFabricPlus (from now own - VFP) protocol target is set to anything below or equal to 1.20.5 would cause it to not work.
The cause: com.viaversion.viafabricplus.injection.mixin.features.movement.collision.MixinEntity injection of "use1_20_6StepCollisionCalculation" to "adjustMovementForCollisions", which renders the injected event(s) useless.
The solution: using MixinSquared to inject into the VFP Mixin generated method, in order to hook the events there as well.
I'm able to do a PR in order to get this fixed.
Steps to reproduce
Target any protocol that is equal to or below 1.20.5
Join a server with that protocol in mind
Set Step mode to 'Instant'
Attempt to Step up 1.0 blocks
Client Log
N/A
Screenshots
No response
The text was updated successfully, but these errors were encountered:
Trol
changed the title
[BUG] Step not functional on ViaFabricPlus set to <= 1.20.5
[BUG] Step [Instant] not functional on ViaFabricPlus set to <= 1.20.5
Jan 17, 2025
LiquidBounce Branch
Nextgen
LiquidBounce Build/Version
any
Operating System
macOS
Minecraft Version
1.21.4
Describe the bug
Attempting to use Step in "Instant" mode when ViaFabricPlus (from now own - VFP) protocol target is set to anything below or equal to 1.20.5 would cause it to not work.
The cause: com.viaversion.viafabricplus.injection.mixin.features.movement.collision.MixinEntity injection of "use1_20_6StepCollisionCalculation" to "adjustMovementForCollisions", which renders the injected event(s) useless.
The solution: using MixinSquared to inject into the VFP Mixin generated method, in order to hook the events there as well.
I'm able to do a PR in order to get this fixed.
Steps to reproduce
Client Log
Screenshots
No response
The text was updated successfully, but these errors were encountered: