Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Step [Instant] not functional on ViaFabricPlus set to <= 1.20.5 #5342

Open
Trol opened this issue Jan 17, 2025 · 2 comments
Open

[BUG] Step [Instant] not functional on ViaFabricPlus set to <= 1.20.5 #5342

Trol opened this issue Jan 17, 2025 · 2 comments
Labels
🐛 bug Something isn't working 🌑 nextgen

Comments

@Trol
Copy link

Trol commented Jan 17, 2025

LiquidBounce Branch

Nextgen

LiquidBounce Build/Version

any

Operating System

macOS

Minecraft Version

1.21.4

Describe the bug

Attempting to use Step in "Instant" mode when ViaFabricPlus (from now own - VFP) protocol target is set to anything below or equal to 1.20.5 would cause it to not work.

The cause: com.viaversion.viafabricplus.injection.mixin.features.movement.collision.MixinEntity injection of "use1_20_6StepCollisionCalculation" to "adjustMovementForCollisions", which renders the injected event(s) useless.

The solution: using MixinSquared to inject into the VFP Mixin generated method, in order to hook the events there as well.

I'm able to do a PR in order to get this fixed.

Steps to reproduce

  • Target any protocol that is equal to or below 1.20.5
  • Join a server with that protocol in mind
  • Set Step mode to 'Instant'
  • Attempt to Step up 1.0 blocks

Client Log

N/A

Screenshots

No response

@github-actions github-actions bot added 🌑 nextgen 🐛 bug Something isn't working labels Jan 17, 2025
@Trol Trol changed the title [BUG] Step not functional on ViaFabricPlus set to <= 1.20.5 [BUG] Step [Instant] not functional on ViaFabricPlus set to <= 1.20.5 Jan 17, 2025
@24dedlaa
Copy link

This also works on the legit mode

@lcxws
Copy link

lcxws commented Jan 21, 2025

look at me

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌑 nextgen
Projects
None yet
Development

No branches or pull requests

3 participants