Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Errors in Pypi release workflow #511

Open
3 of 4 tasks
kamronald opened this issue Jan 27, 2025 · 8 comments · Fixed by #514
Open
3 of 4 tasks

[Bug]: Errors in Pypi release workflow #511

kamronald opened this issue Jan 27, 2025 · 8 comments · Fixed by #514
Assignees
Labels
bug Something isn't working triage

Comments

@kamronald
Copy link
Collaborator

Email (Optional)

No response

Version

v0.5.5

Which OS(es) are you using?

  • MacOS
  • Windows
  • Linux

What happened?

Releasing the latest code version on Pypi does not work. Errors occur when building wheels on MacOS, as can be seen in this latest attempt to run the workflow: https://github.com/CederGroupHub/smol/actions/runs/12920330638/job/36032975433

Perhaps the Github runner systems have changed such that conda is not available? I am currently asking Github support if this is the case.
If this is the case, think we need another way to install openMP. If you have any other ideas, please let me know.

Code snippet

sudo conda create -n build $OPENMP_URL

Log output

sudo: conda: command not found

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kamronald kamronald added bug Something isn't working triage labels Jan 27, 2025
@qchempku2017
Copy link
Collaborator

It seems that macos system on github no longer has conda by default. Maybe we can add conda installation step to the build workflow?

@kamronald
Copy link
Collaborator Author

I will try that right now

@qchempku2017
Copy link
Collaborator

qchempku2017 commented Feb 5, 2025

I will try that right now

Hey man, how's that going? You need any help?

@lbluque
Copy link
Collaborator

lbluque commented Feb 5, 2025

Hi @kamronald and @qchempku2017 - sorry for the delay. I have this fixed in my fork but was also fixing the coverage reports using pytest split. I'll open up a PR asap

@kamronald
Copy link
Collaborator Author

Thanks @lbluque! @qchempku2017 I wasn't able to make it work... but Luis found a way as usual.

@kamronald kamronald reopened this Feb 8, 2025
@kamronald
Copy link
Collaborator Author

Coverage worked when merging PR #514, but then during the release to Pypi it fails... need to find out why

@kamronald
Copy link
Collaborator Author

All the problems in the test and build stages are now solved. There now remains errors when building the docs using the Sphinx package

@qchempku2017
Copy link
Collaborator

All the problems in the test and build stages are now solved. There now remains errors when building the docs using the Sphinx package

Nice, thank you for your continuing dedication!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants