Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meh – log request ids when testing, too #915

Closed
1 task done
nphilipp opened this issue Aug 31, 2023 · 0 comments · Fixed by #916
Closed
1 task done

Meh – log request ids when testing, too #915

nphilipp opened this issue Aug 31, 2023 · 0 comments · Fixed by #916
Assignees
@nphilipp
Labels
API bug tests & CI

Comments

@nphilipp
Copy link
Collaborator

nphilipp commented Aug 31, 2023 •
edited
Loading

Story

As a developer debugging Duffy concurrency issues,
I want tests to log the id of concurrent requests,
so I can tell them apart.

Acceptance Criteria

  • When testing API calls, captured logs contain request IDs (fake, continuously incremented ones) to aid in debugging concurrency issues.
@nphilipp nphilipp self-assigned this Aug 31, 2023
nphilipp added a commit to nphilipp/duffy that referenced this issue Aug 31, 2023
@nphilipp
Add short id and optional strings to log records
ca9dd92 
This should really have been in CentOS#914.

Related: CentOS#915

Signed-off-by: Nils Philippsen <[email protected]>
nphilipp added a commit to nphilipp/duffy that referenced this issue Aug 31, 2023
@nphilipp
Tests: Log short request id if present
5fe323c 
Fixes: CentOS#915

Signed-off-by: Nils Philippsen <[email protected]>
@nphilipp nphilipp mentioned this issue Aug 31, 2023
Merged
nphilipp added a commit to nphilipp/duffy that referenced this issue Aug 31, 2023
@nphilipp
Add short id and optional strings to log records
4575e77 
This should really have been in CentOS#914.

Related: CentOS#915

Signed-off-by: Nils Philippsen <[email protected]>
nphilipp added a commit to nphilipp/duffy that referenced this issue Aug 31, 2023
@nphilipp
Tests: Log short request id if present
7879c05 
Fixes: CentOS#915

Signed-off-by: Nils Philippsen <[email protected]>
nphilipp added a commit that referenced this issue Aug 31, 2023
@nphilipp
Add short id and optional strings to log records
2357039 
This should really have been in #914.

Related: #915

Signed-off-by: Nils Philippsen <[email protected]>
nphilipp added a commit that referenced this issue Aug 31, 2023
@nphilipp
Tests: Log short request id if present
6db2d25 
Fixes: #915

Signed-off-by: Nils Philippsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nphilipp nphilipp

Labels
API bug tests & CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests: Log short request id if present nphilipp/duffy
1 participant
@nphilipp