Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1] Deleting conversation from Chats screen crashes JSQ #326

Closed
chrisballinger opened this issue Mar 25, 2015 · 0 comments
Closed

[3.1] Deleting conversation from Chats screen crashes JSQ #326

chrisballinger opened this issue Mar 25, 2015 · 0 comments
Milestone
3.1

Comments

@chrisballinger
Copy link
Member

Crashes on L701 of OTRMessagesViewController: NSAssert(row < [self.messageMappings numberOfItemsInSection:section], @"Cannot fetch message because row %d is >= numberOfItemsInSection %d", (int)row, (int)[self.messageMappings numberOfItemsInSection:section]);

Looks like after deleting the chat messages the mappings is no longer synced with the collection view. Possible fix would be to force-reload the collection view after being informed of the deletion.
@davidchiles davidchiles added this to the 3.1 milestone Mar 25, 2015
davidchiles added a commit that referenced this issue Mar 25, 2015
@davidchiles
Fix #326 Cleanup add/deleting/updating messages
8d7ebcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
2 participants
@davidchiles @chrisballinger