Skip to content

Commit c8046ad

Browse files
committed
Skip eventmanager_libuv_test under TSAN
1 parent 777792b commit c8046ad

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

test/core/iomgr/poller/BUILD

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ grpc_cc_test(
2828
"gtest",
2929
],
3030
language = "C++",
31+
tags = [
32+
# TSAN has a false-positive for ShutdownRefAsync
33+
# https://github.com/grpc/grpc/issues/24242
34+
"notsan",
35+
],
3136
uses_polling = False,
3237
deps = [
3338
"//:eventmanager_libuv",

test/core/iomgr/poller/eventmanager_libuv_test.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,10 @@ TEST(LibuvEventManager, ShutdownRefAsync) {
5858
for (int j = 0; j < i; j++) {
5959
em->ShutdownRef();
6060
}
61+
// TSAN doesn't like this approach although this would work. TSAN considers
62+
// it dangerous to have a destructor being called while its member function
63+
// is called but LibuvEventManager handles this by making LibuvEventManager
64+
// wait until all pending operations finish.
6165
grpc_core::Thread deleter(
6266
"deleter", [](void* em) { delete static_cast<LibuvEventManager*>(em); },
6367
em);

0 commit comments

Comments
 (0)