Skip eventmanager_libuv_test under TSAN

ClickHouse · Oct 1, 2020 · c8046ad · c8046ad
1 parent 777792b
commit c8046ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/test/core/iomgr/poller/BUILD b/test/core/iomgr/poller/BUILD
@@ -28,6 +28,11 @@ grpc_cc_test(
         "gtest",
     ],
     language = "C++",
+    tags = [
+        # TSAN has a false-positive for ShutdownRefAsync
+        # https://github.com/grpc/grpc/issues/24242
+        "notsan",
+    ],
     uses_polling = False,
     deps = [
         "//:eventmanager_libuv",

diff --git a/test/core/iomgr/poller/eventmanager_libuv_test.cc b/test/core/iomgr/poller/eventmanager_libuv_test.cc
@@ -58,6 +58,10 @@ TEST(LibuvEventManager, ShutdownRefAsync) {
     for (int j = 0; j < i; j++) {
       em->ShutdownRef();
     }
+    // TSAN doesn't like this approach although this would work. TSAN considers
+    // it dangerous to have a destructor being called while its member function
+    // is called but LibuvEventManager handles this by making LibuvEventManager
+    // wait until all pending operations finish.
     grpc_core::Thread deleter(
         "deleter", [](void* em) { delete static_cast<LibuvEventManager*>(em); },
         em);