Skip to content

Commit a60e26c

Browse files
committed
refactor: Optimize getBounding
1 parent beee147 commit a60e26c

File tree

1 file changed

+18
-11
lines changed

1 file changed

+18
-11
lines changed

src/litegraph.js

+18-11
Original file line numberDiff line numberDiff line change
@@ -3781,25 +3781,32 @@
37813781
LGraphNode.prototype.getBounding = function(out, compute_outer) {
37823782
out = out || new Float32Array(4);
37833783
const nodePos = this.pos;
3784-
const nodeFlags = this.flags;
3784+
const isCollapsed = this.flags.collapsed;
37853785
const nodeSize = this.size;
37863786

3787-
// 4 offset for collapsed node connection points
3788-
const left_offset = compute_outer ? 4 : 0;
3789-
// 6 offset for right shadow and collapsed node connection points, 1 offset due to how nodes are rendered
3790-
const right_offset = compute_outer ? 6 + left_offset : 1 ;
3791-
// 4 offset for collapsed nodes top connection points
3792-
const top_offset = compute_outer ? 4 : 0;
3793-
// 5 offset for bottom shadow and collapsed node connection points
3794-
const bottom_offset = compute_outer ? 5 + top_offset : 0;
3787+
let left_offset = 0;
3788+
// 1 offset due to how nodes are rendered
3789+
let right_offset = 1 ;
3790+
let top_offset = 0;
3791+
let bottom_offset = 0;
37953792

3793+
if (compute_outer) {
3794+
// 4 offset for collapsed node connection points
3795+
left_offset = 4;
3796+
// 6 offset for right shadow and collapsed node connection points
3797+
right_offset = 6 + left_offset;
3798+
// 4 offset for collapsed nodes top connection points
3799+
top_offset = 4;
3800+
// 5 offset for bottom shadow and collapsed node connection points
3801+
bottom_offset = 5 + top_offset;
3802+
}
37963803

37973804
out[0] = nodePos[0] - left_offset;
37983805
out[1] = nodePos[1] - LiteGraph.NODE_TITLE_HEIGHT - top_offset;
3799-
out[2] = nodeFlags.collapsed ?
3806+
out[2] = isCollapsed ?
38003807
(this._collapsed_width || LiteGraph.NODE_COLLAPSED_WIDTH) + right_offset :
38013808
nodeSize[0] + right_offset;
3802-
out[3] = nodeFlags.collapsed ?
3809+
out[3] = isCollapsed ?
38033810
LiteGraph.NODE_TITLE_HEIGHT + bottom_offset :
38043811
nodeSize[1] + LiteGraph.NODE_TITLE_HEIGHT + bottom_offset;
38053812

0 commit comments

Comments
 (0)