Merge pull request #30 from Codeception/SamMousa-patch-1

Naktibalda · web-flow · commit 8604bd7964ce · 2021-03-02T08:58:56.000+02:00
Fix `TypeError` in PHP8
diff --git a/src/Codeception/Lib/InnerBrowser.php b/src/Codeception/Lib/InnerBrowser.php
@@ -1430,7 +1430,7 @@ static function (Crawler $node) use ($attr, $val) {
 
     public function grabTextFrom($cssOrXPathOrRegex)
     {
-        if (@preg_match($cssOrXPathOrRegex, $this->client->getInternalResponse()->getContent(), $matches)) {
+        if (is_string($cssOrXPathOrRegex) && @preg_match($cssOrXPathOrRegex, $this->client->getInternalResponse()->getContent(), $matches)) {
             return $matches[1];
         }
         $nodes = $this->match($cssOrXPathOrRegex);

Original file line number	Diff line number	Diff line change
`@@ -1430,7 +1430,7 @@ static function (Crawler $node) use ($attr, $val) {`
`1430`	`1430`
`1431`	`1431`	`public function grabTextFrom($cssOrXPathOrRegex)`
`1432`	`1432`	`{`
`1433`		`- if (@preg_match($cssOrXPathOrRegex, $this->client->getInternalResponse()->getContent(), $matches)) {`
	`1433`	`+ if (is_string($cssOrXPathOrRegex) && @preg_match($cssOrXPathOrRegex, $this->client->getInternalResponse()->getContent(), $matches)) {`
`1434`	`1434`	`return $matches[1];`
`1435`	`1435`	`}`
`1436`	`1436`	`$nodes = $this->match($cssOrXPathOrRegex);`