[InnerBrowser] clickButton throws exception if button is outside form or link (#5478)

Naktibalda · DavertMik · commit 5d2dae914366 · 2019-04-24T02:39:13.000+03:00
Fixes #5425
diff --git a/tests/data/app/view/form/button-not-in-form.php b/tests/data/app/view/form/button-not-in-form.php
@@ -1,7 +1,15 @@
 <html>
 <body>
+
 <div>
-    <button>The Button</button>
+    <form action="/form/button" method="POST" id="form-id">
+        <input type="hidden" name="text" value="val" />
+        <button type="submit" name="btn0">Submit</button>
+    </form>
+</div>
+
+<div>
+    <input type="submit" form="form-id" value="Submit 2" />
 </div>
 </body>
 </html>
diff --git a/tests/unit/Codeception/Module/PhpBrowserTest.php b/tests/unit/Codeception/Module/PhpBrowserTest.php
@@ -1,5 +1,6 @@
 <?php
 
+use Codeception\Exception\TestRuntimeException;
 use Codeception\Util\Stub;
 
 require_once 'tests/data/app/data.php';
@@ -604,9 +605,10 @@ public function testClickSelectsClickableElementFromMatchesUsingCssLocator()
 
     public function testClickingOnButtonOutsideFormDoesNotCauseFatalError()
     {
-        $this->expectException(AssertionFailedError::class);
+        $this->expectException(TestRuntimeException::class);
+        $this->expectExceptionMessage('Button is not inside a link or a form');
         $this->module->amOnPage('/form/button-not-in-form');
-        $this->module->click('The Button');
+        $this->module->click(['xpath' => '//input[@type="submit"][@form="form-id"]']);
     }
 
     public function testSubmitFormWithoutEmptyOptionsInSelect()
