Use expectException method instead of annotation in tests

Naktibalda · Naktibalda · commit da9bd2637943 · 2019-02-24T18:03:57.000+02:00
diff --git a/tests/unit/Codeception/Module/PhpBrowserTest.php b/tests/unit/Codeception/Module/PhpBrowserTest.php
@@ -7,6 +7,7 @@
 
 use GuzzleHttp\Handler\MockHandler;
 use GuzzleHttp\Psr7\Response;
+use PHPUnit\Framework\AssertionFailedError;
 
 class PhpBrowserTest extends TestsForBrowsers
 {
@@ -617,11 +618,9 @@ public function testClickSelectsClickableElementFromMatchesUsingCssLocator()
         $this->module->seeCurrentUrlEquals('/info');
     }
 
-    /**
-     * @expectedException PHPUnit\Framework\AssertionFailedError
-     */
     public function testClickingOnButtonOutsideFormDoesNotCauseFatalError()
     {
+        $this->expectException(AssertionFailedError::class);
         $this->module->amOnPage('/form/button-not-in-form');
         $this->module->click('The Button');
     }

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`
`8`	`8`	`use GuzzleHttp\Handler\MockHandler;`
`9`	`9`	`use GuzzleHttp\Psr7\Response;`
	`10`	`+use PHPUnit\Framework\AssertionFailedError;`
`10`	`11`
`11`	`12`	`class PhpBrowserTest extends TestsForBrowsers`
`12`	`13`	`{`
`@@ -617,11 +618,9 @@ public function testClickSelectsClickableElementFromMatchesUsingCssLocator()`
`617`	`618`	`$this->module->seeCurrentUrlEquals('/info');`
`618`	`619`	`}`
`619`	`620`
`620`		`- /**`
`621`		`- * @expectedException PHPUnit\Framework\AssertionFailedError`
`622`		`- */`
`623`	`621`	`public function testClickingOnButtonOutsideFormDoesNotCauseFatalError()`
`624`	`622`	`{`
	`623`	`+ $this->expectException(AssertionFailedError::class);`
`625`	`624`	`$this->module->amOnPage('/form/button-not-in-form');`
`626`	`625`	`$this->module->click('The Button');`
`627`	`626`	`}`