Comparing changes
Open a pull request
- 10 commits
- 15 files changed
- 1 contributor
Commits on Aug 20, 2016
-
Rename classes, interfaces, attributes and variables in src/ in order…
… to provide Persons semantics
-
* Make
PersonandPersonsPairattributes private* Create constructor for `Person` and `PersonsPair` classes and remove setters * Remove the get prefix from getters * Move the responsibility of calculating the `birthDaysDistanceInSeconds` from the `Finder` to the `PersonsPair` * Throw an exception `NotEnoughPersonsException` in case of receiving not enough persons in order to find a pair. * Refactor the test in order to expect the new exception instead of an empty/inconsistent `PersonsPair`
-
Moderate
FinderCriteriaas a Value Object instead of a plain `inter……face` with two `const`
-
Improve
Finderclass readability:* Extract private methods from the `Finder::find` public one * Replace `$i` and `$j` index by the more semantic ones `$currentPersonIteration` and `$personToPairIteration` * Extract `$currentPerson` and `$personToPair` explanatory variables
-
Make the Finder OCP (Open/Closed SOLID Principle) compliant
* Refactor the `FinderCriteria` Value Object into an `interface` and implement it from two different models `ClosestBirthDateCriteria` and `FurthestBirthDateCriteria`. This classes implement the logic to determine which `PersonsPair` `hasMorePriority`. So if we want to add another different criteria, we just need to implement the `PersonsPairCriteria` interface and pass it to the `Finder:: find` method without modifying any `switch` nor `if`/`elseif`.
-
Move the
$allPersonsinput array from theFinderconstructor to t……he `find` method. This way we don't need to create 2 different `Finder` instances in order to execute the algorithm with 2 different inputs, and more importantly, we leave the constructor ready in order to only receive collaborator as parameters
-
Extract the responsibility of pair all the
Personreceived as the `……Finder::find` input into the new `PersonsPairer` interface allowing also OCP applications on that end
-
Extract the responsibility of constructing the
PersonsPairfrom the…… `PersonsPairer` to its own `PersonsPairFactory`. This way we can mix different `PersonsPairer` implementations without repeating the `PersonsPair` construction logic
-
Rename
PersonsPairer::pairmethod toPersonsPairer::__invokefor ……consistency. We don't need the method name semantics. We're doing little pieces so the semantics could be in the interface or class name by its own
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...02-oop