Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Reloading magazines in creative crashes the game #550

Open
2 of 3 tasks
Desoroxxx opened this issue Dec 5, 2024 · 3 comments
Open
2 of 3 tasks

[DEV] Reloading magazines in creative crashes the game #550

Desoroxxx opened this issue Dec 5, 2024 · 3 comments
Assignees
Labels
Bug Dev Build Specific to a MWC Dev Build Important
Milestone

Comments

@Desoroxxx
Copy link
Collaborator

Desoroxxx commented Dec 5, 2024

Describe the bug

When reloading a magazine in creative it crashes the game due to a NPE.

Fairly sure when I improved the creative reload, I forgot a check for instance or something?

Reproducibility

  • I reproduced this issue with as few other mods as possible installed.
  • I am unable to reproduce this issue consistently.

Screenshots and/or videos

No response

Logs

https://mclo.gs/BOFHF7i

MWC Version

MWC 0.2 Dev 4

Forge Version

1.12.2 - 14.23.5.2860

Red Core Version

0.6 Dev 8

MixinBooter Version

10.2

Java Version

8 - 371

Java Virtual Machine

Hotspot

Operating System

Windows 11

GPU Vendor

NVIDIA

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Desoroxxx
Copy link
Collaborator Author

Thanks to azimuthxzaxis on Discord for reporting this issue

@strubium
Copy link
Contributor

strubium commented Dec 8, 2024

I get a crash when i hold a mag.

adding a null check here prevents the crash, but breaks all of the nice work @Paneedah did with the HUD way back when
image

The HUD doesn't render
2024-12-08_17 35 01

(For future ref this is line 249 of HUD.java)

@Desoroxxx
Copy link
Collaborator Author

Oh I didn't push the fix? Welp guess it will wait until I am back

@strubium strubium added the Dev Build Specific to a MWC Dev Build label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dev Build Specific to a MWC Dev Build Important
Projects
None yet
Development

No branches or pull requests

2 participants