Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS support in nginx reverse proxy #100

Open
9bingyin opened this issue Sep 29, 2024 · 1 comment
Open

ECS support in nginx reverse proxy #100

9bingyin opened this issue Sep 29, 2024 · 1 comment

Comments

@9bingyin
Copy link

I use Nginx to reverse proxy to doh-proxy because I want to use multiple paths to distinguish between different sources of DoH requests. However, I find that regardless of whether I use X-Real-IP or X-Forwarded-For to pass the upstream IP, it ultimately does not get applied to doh-proxy. However, the ECS directly attached by the upstream client (e.g., dig +subnet) is passed through.

I also didn't see any related information in the Usage section. Does doh-proxy not support this feature, or could there be an issue with my configuration?

@jedisct1
Copy link
Member

The server doesn't add the client subnet implicitly. It's only sent to upstream servers if the client explicitly asked for it (for example by setting the edns_client_subnet parameter in dnscrypt-proxy).

From a privacy perspective, this is much better that way.

But I can try to add an option to do it implicitly, even though it would be disabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants