Raise OverflowError is the index for list.index() overflows

Author: shinglyu

tests/snippets/list.py

@@ -60,3 +60,10 @@
 x = ['a', 'b', 'c']
 x.insert(-100, 'z')
 assert x == ['z', 'a', 'b', 'c']
+
+try:
+    x.insert(100000000000000000000, 'z')
+except OverflowError:
+    pass
+else:
+    assert False, "OverflowError was not raised"

vm/src/obj/objlist.rs

@@ -277,6 +277,9 @@ fn list_insert(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
             (element, None)
         ]
     );
+    if objint::get_value(insert_position) > std::usize::MAX.into() {
+        return Err(vm.new_overflow_error("Python int too large to convert to Rust usize".to_string()));
+    }
     let mut vec = get_mut_elements(list);
     let position = match objint::get_value(insert_position) {
         ref i if (*i).is_negative() => {

vm/src/vm.rs

@@ -153,6 +153,11 @@ impl VirtualMachine {
         self.new_exception(zero_division_error, msg)
     }
 
+    pub fn new_overflow_error (&mut self, msg: String) -> PyObjectRef {
+        let overflow_error = self.ctx.exceptions.overflow_error.clone();
+        self.new_exception(overflow_error, msg)
+    }
+
     pub fn new_scope(&mut self, parent_scope: Option<PyObjectRef>) -> PyObjectRef {
         // let parent_scope = self.current_frame_mut().locals.clone();
         self.ctx.new_scope(parent_scope)