Read target frame on hyperlinks

Dan503 · May 30, 2017 · a966168 · a966168
1 parent 9cc065c
commit a966168
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 4 deletions.
diff --git a/lib/documents.js b/lib/documents.js
@@ -81,7 +81,8 @@ function Hyperlink(children, options) {
         type: types.hyperlink,
         children: children,
         href: options.href,
-        anchor: options.anchor
+        anchor: options.anchor,
+        targetFrame: options.targetFrame
     };
 }
 

diff --git a/lib/docx/body-reader.js b/lib/docx/body-reader.js
@@ -208,14 +208,23 @@ function BodyReader(options) {
             var relationshipId = element.attributes["r:id"];
             var anchor = element.attributes["w:anchor"];
             return readXmlElements(element.children).map(function(children) {
+                function create(options) {
+                    var targetFrame = element.attributes["w:tgtFrame"];
+
+                    return new documents.Hyperlink(
+                        children,
+                        _.extend({targetFrame: targetFrame}, options)
+                    );
+                }
+
                 if (relationshipId) {
                     var href = relationships[relationshipId].target;
                     if (anchor) {
                         href = uris.replaceFragment(href, anchor);
                     }
-                    return new documents.Hyperlink(children, {href: href});
+                    return create({href: href});
                 } else if (anchor) {
-                    return new documents.Hyperlink(children, {anchor: anchor});
+                    return create({anchor: anchor});
                 } else {
                     return children;
                 }

diff --git a/test/docx/body-reader.tests.js b/test/docx/body-reader.tests.js
@@ -945,7 +945,16 @@ test("w:hyperlink", {
         var hyperlinkXml = new XmlElement("w:hyperlink", {}, [runXml]);
         var result = readXmlElement(hyperlinkXml);
         assert.deepEqual(result.value[0].type, "run");
-    }
+    },
+
+    "target frame is read": function() {
+        var hyperlinkXml = new XmlElement("w:hyperlink", {
+            "w:anchor": "Introduction",
+            "w:tgtFrame": "_blank"
+        });
+        var result = readXmlElementValue(hyperlinkXml);
+        assertThat(result, hasProperties({targetFrame: "_blank"}));
+    },
 });
 
 test("w:br without explicit type is read as line break", function() {