Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly outdated claim about number of Postgres metrics generated per relation #11642

Open
patbl opened this issue Mar 9, 2022 · 0 comments
Assignees

Comments

@patbl
Copy link

patbl commented Mar 9, 2022

This comment claims that each Postgres relation that metrics are enabled for generates "10 + 10 per index" metrics:

## Each relation generates many metrics (10 + 10 per index).

That was probably right when the comment was written, but I think there are more now. Here are the ones that seem to be defined in RELATION_METRICS:

RELATION_METRICS = [LOCK_METRICS, REL_METRICS, IDX_METRICS, SIZE_METRICS, STATIO_METRICS]

postgresql.locks
postgresql.autoanalyzed
postgresql.live_rows
postgresql.vacuumed
postgresql.rows_deleted
postgresql.autovacuumed
postgresql.rows_updated
postgresql.seq_rows_read
postgresql.seq_scans
postgresql.analyzed
postgresql.index_rel_rows_fetched
postgresql.rows_inserted
postgresql.rows_hot_updated
postgresql.index_rel_scans
postgresql.dead_rows
postgresql.index_rows_read
postgresql.index_scans
postgresql.index_rows_fetched
postgresql.index_size
postgresql.total_size
postgresql.table_size
postgresql.toast_index_blocks_read
postgresql.toast_index_blocks_hit
postgresql.toast_blocks_read
postgresql.index_blocks_read
postgresql.heap_blocks_read
postgresql.index_blocks_hit
postgresql.toast_blocks_hit
postgresql.heap_blocks_hit

That's 29. Maybe the comment could be updated to say "at least" the whatever the current figures are.

@patbl patbl changed the title Possibly inaccurate claim about number of Postgres metrics generated per relation Possibly outdated claim about number of Postgres metrics generated per relation Mar 9, 2022
@xcoderzach xcoderzach self-assigned this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants