Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DeCarabas/fwd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: DeCarabas/fwd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: quodlibetor/add-docker-ports
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Jul 31, 2024

  1. feat: Show errored ports as an error state

    @quodlibetor @DeCarabas
    quodlibetor authored and DeCarabas committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    66da323 View commit details
    Browse the repository at this point in the history

  2. feat: Discover docker ports as well 

    If processes are running in a container then the fwd process
can't read their internal FDs without the CAP_SYS_ADMIN property
which is equivalent to sudo. Even with sudo, I think you need to do
a lot of work to be able to read them -- spawning a process within
the cgroup, doing work there, and then communicating back.

This just uses the docker api to populate some default ports, which
later get overwritten if fwd can find a native process.

The Docker port scan takes about 1.5ms, and the full port scan takes
40+ms, so this adds basically no overhead.
    @quodlibetor @DeCarabas
    quodlibetor authored and DeCarabas committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    6c10d8e View commit details
    Browse the repository at this point in the history

  3. make server logging show messages in the frontend 

    now you can use the log crate and get messages in the frontend.
    @quodlibetor @DeCarabas
    quodlibetor authored and DeCarabas committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    05c0a0a View commit details
    Browse the repository at this point in the history
Loading