-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-assess bug-related TODOs in scripts #240
Comments
I fixed the require.py ones in my branch yesterday, I also noticed that we are leaking a |
The XMLHttpRequest* symbols are okay - they are present in the browser |
only the one in global-init.js remains |
Issue type
Other
How did you install PythonMonkey?
None
OS platform and distribution
No response
Python version (
python --version
)No response
PythonMonkey version (
pip show pythonmonkey
)No response
Bug Description
These TODO comments were left around. Are we now able to act on them?
require.py:
A better implementation in Python that doesn't leak global symbols should be possible once some PythonMonkey bugs are fixed.
global-init.js:
due to current bugs in PythonMonkey, we can't access the cache property of require because it is a JS function wrapped in a Python function wrapper exposed to script as a native function.
pmjs.py:
The global require is to the JS function using a trick instead of a JS-wrapped-Python-wrapped function
Standalone code to reproduce the issue
No response
Relevant log output or backtrace
No response
Additional info if applicable
No response
What branch of PythonMonkey were you developing on? (If applicable)
No response
The text was updated successfully, but these errors were encountered: