-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Feature Request regarding Dict subclasses #257
Comments
This is incorrect: |
We will post a feature request to the relevant Python forum for this one |
let's keep it open until post has been done and as a follow-up on the post |
@philippedistributive Wes says to, if you like, make a separate ticket for posting a feature request to the python team, but this ticket should not be blocking v1.0.0 |
Issue type
Bug
How did you install PythonMonkey?
None
OS platform and distribution
No response
Python version (
python --version
)No response
PythonMonkey version (
pip show pythonmonkey
)No response
Bug Description
This was an explicit design goal and I just found out that it doesn't work anymore.
If we can't create Dicts from JS, we can't use Python libraries that use Dicts.
Ironically, one such library is PythonMonkey, which uses Dicts to pass evaluation options to spidermonkey. And because JSObjectProxy is not a py_dict, PyDict_GetItemString doesn't find the filename, which is why the stack traces for the modules no longer include their filenames.
There must be a solution to this problem.
Standalone code to reproduce the issue
No response
Relevant log output or backtrace
No response
Additional info if applicable
No response
What branch of PythonMonkey were you developing on? (If applicable)
No response
The text was updated successfully, but these errors were encountered: