You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Module filenames now all show as evaluate in stack traces, which is really useless.
This is because ctx-module communicates the filenames to spidermonkey via vm.runInContext, which uses the options argument to eval to specify the filename. This doesn't work anymore because the JS code passes a JS option but the getEvalOptions() code needs a Python Dict for PyDict_GetItemString() to work. So it always finds a null filename.
Standalone code to reproduce the issue
No response
Relevant log output or backtrace
No response
Additional info if applicable
No response
What branch of PythonMonkey were you developing on? (If applicable)
No response
The text was updated successfully, but these errors were encountered:
This worked initially when JS->python objects were implemented by a naive copy to a dict, rather than proxying a JS object.
Was broken since the introduction of JSObjectProxy
Issue type
Bug
How did you install PythonMonkey?
None
OS platform and distribution
No response
Python version (
python --version
)No response
PythonMonkey version (
pip show pythonmonkey
)No response
Bug Description
This worked last year.
Module filenames now all show as
evaluate
in stack traces, which is really useless.This is because ctx-module communicates the filenames to spidermonkey via vm.runInContext, which uses the options argument to eval to specify the filename. This doesn't work anymore because the JS code passes a JS option but the getEvalOptions() code needs a Python Dict for PyDict_GetItemString() to work. So it always finds a null filename.
Standalone code to reproduce the issue
No response
Relevant log output or backtrace
No response
Additional info if applicable
No response
What branch of PythonMonkey were you developing on? (If applicable)
No response
The text was updated successfully, but these errors were encountered: