Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module filenames missing from stack traces #258

Closed
wesgarland opened this issue Mar 1, 2024 · 2 comments · Fixed by #262
Closed

Module filenames missing from stack traces #258

wesgarland opened this issue Mar 1, 2024 · 2 comments · Fixed by #262
Assignees

Comments

@wesgarland
Copy link
Collaborator

wesgarland commented Mar 1, 2024

Issue type

Bug

How did you install PythonMonkey?

None

OS platform and distribution

No response

Python version (python --version)

No response

PythonMonkey version (pip show pythonmonkey)

No response

Bug Description

This worked last year.

Module filenames now all show as evaluate in stack traces, which is really useless.

This is because ctx-module communicates the filenames to spidermonkey via vm.runInContext, which uses the options argument to eval to specify the filename. This doesn't work anymore because the JS code passes a JS option but the getEvalOptions() code needs a Python Dict for PyDict_GetItemString() to work. So it always finds a null filename.

Standalone code to reproduce the issue

No response

Relevant log output or backtrace

No response

Additional info if applicable

No response

What branch of PythonMonkey were you developing on? (If applicable)

No response

@wesgarland
Copy link
Collaborator Author

Fixing PR257 would fix this

@philippedistributive
Copy link
Collaborator

This worked initially when JS->python objects were implemented by a naive copy to a dict, rather than proxying a JS object.
Was broken since the introduction of JSObjectProxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants