Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstalling pythonmonkey does not install pminit #430

Closed
wesgarland opened this issue Sep 8, 2024 · 0 comments · Fixed by #431
Closed

uninstalling pythonmonkey does not install pminit #430

wesgarland opened this issue Sep 8, 2024 · 0 comments · Fixed by #431
Assignees
Milestone

Comments

@wesgarland
Copy link
Collaborator

wesgarland commented Sep 8, 2024

Issue type

Bug

How did you install PythonMonkey?

Installed from pip

OS platform and distribution

macOs 10.15.7

Python version (python --version)

3.11.4

PythonMonkey version (pip show pythonmonkey)

0.8.2.dev25+c8aa8d7

Bug Description

I installed a pythonmonkey nightly
Then I uninstalled it, so that I could reinstall the current release
It left behind pminit, which is understandable but annoying and slightly user-hostile

Proceed (Y/n)? Y
  Successfully uninstalled pythonmonkey-0.8.2.dev25+c8aa8d7
[~] Wes-iMac-2019:wes# python
Python 3.11.4 (main, Jul 17 2023, 10:45:54) [Clang 11.0.3 (clang-1103.0.32.59)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import pminit
>>> pminit
<module 'pminit' from '/usr/local/lib/python3.11/site-packages/pminit/__init__.py'>

We need to either clean up pminit in a hook during uninstall, or update the install docs to tell folks how to properly uninstall. The first solution is a much more preferable solution, but either is okay for 1.0.

Standalone code to reproduce the issue

No response

Relevant log output or backtrace

No response

Additional info if applicable

No response

What branch of PythonMonkey were you developing on? (If applicable)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants