Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject menu active/open highlights are a little off #25

Closed
briandominick opened this issue May 23, 2021 · 1 comment · Fixed by #37
Closed

Subject menu active/open highlights are a little off #25

briandominick opened this issue May 23, 2021 · 1 comment · Fixed by #37
Labels
bug Something isn't working CSS/Sass Involves hacking some styles Liquid Incorporates Liquid templating
Milestone

Comments

@briandominick
Copy link
Contributor

Our Navgoco implementation (the left nav menu) uses the classes active and open to keep track of what submenus to expand and what active links to highlight. It is supposed to strongly highlight the link to the page the browser is on (this works) and subtly highlight the submenu containing the page the browser is on (this partly works).

navgoco-quirks-1
navgoco-quirks-2

@briandominick briandominick added bug Something isn't working Liquid Incorporates Liquid templating CSS/Sass Involves hacking some styles labels May 23, 2021
@briandominick
Copy link
Contributor Author

A third problem is represented here:

navgoco-quirks-3

This is the default behavior when landing on the Search Config topic page or even clicking "Configure Search" in the subject nav without clicking the collapse caret.

If you are on a topic that has a submenu, the submenu should be open and subtly highlighted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CSS/Sass Involves hacking some styles Liquid Incorporates Liquid templating
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant