-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to NET8 #2689
Comments
Net8 is not compatible with the current version of VoiceAttack. |
I've added #2690 with the solution that I've been considering to allow framework updates. |
Note: I should also note that ports which I've tested in Net8 have actually lost access to some older 32 bit voices as well. |
I guess then this is the deal breaker for port to net8, I don't use VoiceAttack my self so didn't try that. I don't know what was missing but the same piece of code when executes in 4.8 and in net8 return different voices. So this piece of code I used for testing
In net8 would return following (I'll just write name) plus 10 more voices. While when I execute it in 4.8 I would get: Name: Microsoft David Desktop which is the same I get in EDDI. Feel free to close the issue since it won't work with VoiceAttack.
This is probably due to 64bit build of app I guess installation of 32bit runtime and building app as 32bit would fix that but I don't have 32bit specific voice to test this. |
I may be misunderstanding the original issue here, but I'm using that NaturalVoiceSAPIAdapter to add several new MS Narrator voices to EDDI, and it works perfectly fine for me. I've not done anything special with my installation either. If I have misunderstood, then please forgive my intrusion on this topic. Edit: Just wanted to add that I know another user has added MS Azure voices to EDDI using the same SAPI adapter. |
Thanks @Darkcyde13 for the additional perspective. @seba76 it sounds like there may be some issue that is specific to your PC. You might want to try combining EDDI + NaturalVoiceSAPIAdapter on a second PC to test this. If it still fails then I'd be curious about the exceptions recorded in eddi.log. |
I've attached log from EDDI but I don't see anything special in it, Elite was not running when I created this log. Will spin up VM to test what is going on with clean install and let you know my findings. |
I figured out what was the problem. On clean install of Windows 11 24H2 with added Jenny as narrator voice I installed NaturalVoiceSAPIAdapter like this picture shows then I get this in EDDI Then I remembered that @Tkael mentiond 32bit so once I installed 32bit I got What I didn't realize was that EDDI was actually build as 32bit application and that is the reason it was not working. Thanks @Darkcyde13 for the info without it i would never caught it. @Tkael you can close the issue in my opinion since it is not related to framework, although it might be good idea to port it to Net at some point. |
What happens now
Well suggestion for this came from my playing with available languages that I could select. I came a cross NaturalVoiceSAPIAdapter which enables additional voices in net8 sample app I had. When I tried it in current version of EDDI 4.1.0-b3 when running on Windows 11 those new languages where not visible. Quick test showed that that was due to Net Framework used in EDDI.
What I'd like to happen
I would suggest porting EDDI to net8 to give it more opportunity for future enhancements from framework updates. This is partly related to #2379.
How it can happen
You can check out my quick hack job in porting at net8 repo to see what is required to make it work. Basically what I did is:
EDDI Version
Changes are done on development branch.
The text was updated successfully, but these errors were encountered: