Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SmartSkip] On windows, powershell [Get-FileHash] can take up to 1x seconds on the first run #151

Open
Mark-Joy opened this issue Jun 14, 2024 · 1 comment

Comments

@Mark-Joy
Copy link

Hello,
As title, please don't use powershell since this tool can take a long time (up to 1x seconds) on the first run (after restart/login computer). My processor is Intel i3-6100.
And it take an average of 300-ms on subsequent runs (not a problem after the first run).

To reproduce the issue:

  • Restart computer. Wait for it to complete boot up.
  • Open any video file.

Here are 2 examples:
powershell-9550
powershell-17727

Consider to use pure-lua-hash instead. It takes only 1-ms to complete not only MD5 but also sha256. And you don't have to run subprocess command.
Here is the commit: 1fccdb5 that use pure_lua_SHA
You can also choose SHA256 instead of MD5.

pure-lua-hash

@Eisa01
Copy link
Owner

Eisa01 commented Jun 18, 2024

I really like it, however, loading and downloading additional scripts might be a problem for some of the non-tech users. Sadly, there is no way around it :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants