Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace inside templates causes logical failure #30

Closed
rgwozdz opened this issue Oct 12, 2018 · 2 comments
Closed

whitespace inside templates causes logical failure #30

rgwozdz opened this issue Oct 12, 2018 · 2 comments
Assignees
Labels

Comments

@rgwozdz
Copy link
Contributor

rgwozdz commented Oct 12, 2018

Consider a template like:

{
  "title": "{{crashLayer.title || test}}"
}

And settings like:

{
  "crashLayer": {
    "title": "2008 Collisions"
  }
}

We get the result from adlib:

{
  "title": " test"
}

when what we really want is "title": "2008 Collisions". This occurs because leading/trailing whitespace in handlebars content is not being fully handled/trimmed during parsing.

@rgwozdz rgwozdz added the bug label Oct 12, 2018
@rgwozdz rgwozdz self-assigned this Oct 12, 2018
@tomwayson
Copy link
Member

This was closed via #31 right?

@jgravois
Copy link
Contributor

released as v2.3.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants