-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [HOLD for payment 2025-02-05] [HybridApp][Fire Clean Up] Create HybridApp CI Test #54323
Comments
Adding the |
@AndrewGable Huh... This is 4 days overdue. Who can take care of this? |
@AndrewGable 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
@AndrewGable 10 days overdue. I'm getting more depressed than Marvin. |
@AndrewGable 12 days overdue. Walking. Toward. The. Light... |
This issue has not been updated in over 14 days. @AndrewGable eroding to Weekly issue. |
Weekly is fine, I will look into this soon. |
All Fire-Cleanups should be Daily, as "THERE IS NOTHING HIGHER PRIORITY THAN THESE ISSUES THAT YOU SHOULD BE WORKING ON". If this shouldn't be Daily, then it isn't a Fire-Cleanup. |
Currently fighting another fire, but OK sounds good 👍 |
PR is up |
Basic outline of the CI/CD is up but builds are failing, looking into it today https://github.com/react-native-community/cli/blob/main/packages/cli-platform-ios/README.md#build-ios |
Android is finally working, still working on iOS. |
Android is now failing on subsequent builds, I think it's an issue with cache. Looking into it. |
Both iOS and Android builds are working, but we should look into this issue first: #55659 Otherwise Android builds will be flaky |
cc @staszekscp - What file types would you think we should run this test on? This seems like a good list: https://github.com/Expensify/App/blob/main/.github/workflows/commentOnNativeFileChanged.yml#L7-L15 Are there any other file types we should add? |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
@AndrewGable Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@AndrewGable does @shubham1206agra need payment here? |
Yes, for reviewing the pr 👍 |
Job added to Upwork: https://www.upwork.com/jobs/~021889660993277490490 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov ( |
📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@shubham1206agra offer out to you! |
@garrettmknight Let me confirm the mode of payment here. @mallenexpensify The job was exported as well as assigned to me today. So should I be eligible for payment through NewDot for this issue or not? |
@mallenexpensify bump |
@shubham1206agra we should pay via Upwork. Even though you were assigned after your eligibility date, you worked on the associated PR before (and, in a perfect world, would have been assigned then) |
@garrettmknight Offer accepted |
Cool, all paid up! |
See https://expensify.enterprise.slack.com/canvas/C085GD1ET8A
Problem
We need a CI test to verify that HybridApp builds on each PR commit to App
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @garrettmknightThe text was updated successfully, but these errors were encountered: