Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2025-02-05] [HybridApp][Fire Clean Up] Create HybridApp CI Test #54323

Closed
grgia opened this issue Dec 18, 2024 · 31 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Fire-Cleanup Something needs to be done after a fire

Comments

@grgia
Copy link
Contributor

grgia commented Dec 18, 2024

See https://expensify.enterprise.slack.com/canvas/C085GD1ET8A

Problem

We need a CI test to verify that HybridApp builds on each PR commit to App

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021889660993277490490
  • Upwork Job ID: 1889660993277490490
  • Last Price Increase: 2025-02-12
  • Automatic offers:
    • shubham1206agra | Contributor | 106095912
Issue OwnerCurrent Issue Owner: @garrettmknight
@grgia grgia added the Daily KSv2 label Dec 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
@puneetlath puneetlath added the Fire-Cleanup Something needs to be done after a fire label Dec 23, 2024
@puneetlath
Copy link
Contributor

Adding the Fire-Cleanup label here. From #fireroom-2024-12-17-hybridapp-crash

@puneetlath puneetlath changed the title [HybridApp][Fire Clean Up] Create CI Test [HybridApp][Fire Clean Up] Create HybridApp CI Test Dec 23, 2024
Copy link

melvin-bot bot commented Dec 24, 2024

@AndrewGable Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Dec 26, 2024

@AndrewGable 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Dec 30, 2024

@AndrewGable 10 days overdue. I'm getting more depressed than Marvin.

Copy link

melvin-bot bot commented Jan 1, 2025

@AndrewGable 12 days overdue. Walking. Toward. The. Light...

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

This issue has not been updated in over 14 days. @AndrewGable eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Jan 6, 2025
@AndrewGable
Copy link
Contributor

Weekly is fine, I will look into this soon.

@flodnv flodnv added Daily KSv2 and removed Weekly KSv2 labels Jan 14, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 14, 2025
@flodnv
Copy link
Contributor

flodnv commented Jan 14, 2025

All Fire-Cleanups should be Daily, as "THERE IS NOTHING HIGHER PRIORITY THAN THESE ISSUES THAT YOU SHOULD BE WORKING ON". If this shouldn't be Daily, then it isn't a Fire-Cleanup.

@AndrewGable
Copy link
Contributor

Currently fighting another fire, but OK sounds good 👍

@AndrewGable
Copy link
Contributor

PR is up

@AndrewGable
Copy link
Contributor

@AndrewGable
Copy link
Contributor

Android is finally working, still working on iOS.

@AndrewGable
Copy link
Contributor

Android is now failing on subsequent builds, I think it's an issue with cache. Looking into it.

@AndrewGable
Copy link
Contributor

Both iOS and Android builds are working, but we should look into this issue first: #55659

Otherwise Android builds will be flaky

@AndrewGable
Copy link
Contributor

cc @staszekscp - What file types would you think we should run this test on? This seems like a good list: https://github.com/Expensify/App/blob/main/.github/workflows/commentOnNativeFileChanged.yml#L7-L15

Are there any other file types we should add?

@melvin-bot melvin-bot bot removed the Daily KSv2 label Jan 24, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Feb 3, 2025
Copy link

melvin-bot bot commented Feb 5, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Copy link

melvin-bot bot commented Feb 11, 2025

@AndrewGable Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@garrettmknight
Copy link
Contributor

@AndrewGable does @shubham1206agra need payment here?

@AndrewGable
Copy link
Contributor

Yes, for reviewing the pr 👍

@garrettmknight garrettmknight added External Added to denote the issue can be worked on by a contributor and removed Reviewing Has a PR in review Awaiting Payment Auto-added when associated PR is deployed to production labels Feb 12, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-02-05] [HybridApp][Fire Clean Up] Create HybridApp CI Test [$250] [HOLD for payment 2025-02-05] [HybridApp][Fire Clean Up] Create HybridApp CI Test Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021889660993277490490

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@garrettmknight garrettmknight added the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 12, 2025
@garrettmknight
Copy link
Contributor

@shubham1206agra offer out to you!

@garrettmknight garrettmknight self-assigned this Feb 12, 2025
@shubham1206agra
Copy link
Contributor

@garrettmknight Let me confirm the mode of payment here.

@mallenexpensify The job was exported as well as assigned to me today. So should I be eligible for payment through NewDot for this issue or not?

@garrettmknight
Copy link
Contributor

@mallenexpensify bump

@mallenexpensify
Copy link
Contributor

@shubham1206agra we should pay via Upwork. Even though you were assigned after your eligibility date, you worked on the associated PR before (and, in a perfect world, would have been assigned then)

@shubham1206agra
Copy link
Contributor

@garrettmknight Offer accepted

@melvin-bot melvin-bot bot added the Overdue label Feb 17, 2025
@garrettmknight
Copy link
Contributor

Cool, all paid up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Fire-Cleanup Something needs to be done after a fire
Projects
None yet
Development

No branches or pull requests

8 participants