[Due for payment 2025-02-26] Bring the "done" report status filter to New Expensify

[MitchExpensify]

Background:

In #wave-collect: Search v2 we introduced a done badge, which shows up within the paid status. We decided against a done or finished default state because the final state for IOUs is paid, and IOUs are not a feature that can be turned off. In a similar fashion for workspaces, the majority of our customers track or make payments (even if they don’t pay in product).

Problem:

The paid report status is confusing for closed reports in New Expensify in two scenarios;

1. When reports without reimbursable expenses are considered paid upon submission.
2. When reports with reimbursable expenses are considered paid upon submission before any payment has been actioned.

Solution:

Stop including closed expense reports that have no reimbursable expenses or reimbursement has not been actioned yet in the paid status filter, and house them in their own done status filter instead. Like Classic, done reports that have reimbursement action on them will move to the paid status filter.

Notes for completeness:

• The status will be positioned between Approved and Paid
• We'll only show the "Done" status if you are on a workspace with approvals disabled
• We'll use this checkbox icon (Figgy for report mock / Figgy for working icons):

Tests:

Preconditions: Use a workspace with approvals disabled

1. Submit a report with 100% reimbursable expenses on it > Verify it enters the closed status
2. Submit a report with 100% non-reimbursable expenses on it > Verify it enters the closed status
3. Submit a report with both reimbursable and non-reimbursables on it > Verify it enters the closed status

[melvin-bot]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

[MitchExpensify]

I think what we need to decide first is what icon we want to use for closed @dannymcclain

[MitchExpensify]

One thing I think is worth mentioning is that being closed is a positive thing in a sense, and maybe that might influence the icon we choose. In other words, when a report is closed, it has been submitted, which means it has progressed down the track toward either payment or export as a next step (depending on whether there are reimbursable expenses on the report or not). Those examples feel a little negative to me for want of a better observation

Also, I think it makes sense to position Closed between Outstanding and Approved when you think about the flow:

Approvals disabled:
Draft > Closed > Paid

Approvals enabled:
Draft > Oustanding > Approved > Paid

[dannymcclain]

Oh hmm I think that does change things 🤔

[trjExpensify]

Will we only show this filter to people that have a workspace with submit&close, is that right?

[MitchExpensify]

Will we only show this filter to people that have a workspace with submit&close, is that right?

Correct but someone could be a member of both types of workspaces so they could see both Closed and Approved

[trjExpensify]

Yeah, in theory, though I'd still vote to put Closed after Approved as it's more of a final state. The delta being submit&closed + payments, but in that case Paid will be last.

[MitchExpensify]

Coming from this thread we landed on doing this: https://expensify.slack.com/archives/C03TME82F/p1738968491101599?thread_ts=1738884571.891239&cid=C03TME82F

• We're naming the status "Done"
• The status will be positioned between Approved and Paid
• We'll only show the "Done" status if you are on a workspace with approvals disabled
• We'll go with this checkbox icon :camera_with_flash:

[dannymcclain]

@dubielzyk-expensify when you have time, will you clean up that icon and properly add it to the library? 🙏

[dubielzyk-expensify]

Will do 👍

[MitchExpensify]

Thanks @dubielzyk-expensify , once we've got the new property added I can label this "new feature" and keep the ball rolling!

[luacmartins]

I'll work on this one

[luacmartins]

@MitchExpensify can you confirm the name we'll use for the filter? The OP says Done, but the mocks say Closed. Which one is it? Can you confirm the icon we should use as well?

[luacmartins]

Got a couple of PRs up, just waiting on the confirmation above

[MitchExpensify]

can you confirm the name we'll use for the filter? The OP says Done, but the mocks say Closed. Which one is it? Can you confirm the icon we should use as well?

It's "done" @luacmartins, @dubielzyk-expensify, can you please share the icon we landed on, please? (The one in the OP)

Thank you!

[luacmartins]

I see that the OP icon for Paid is also different from what we have in product now. Are we changing that @Expensify/design?

[dannymcclain]

@luacmartins I hadn't realized that, but I do kinda think it makes sense to change it? That's the icon we use in the Paid badge and also on the report previews once they're paid. Makes sense to me to keep it the same icon throughout the product.

[shawnborton]

Yeah, I think that's fine and I also think we'll eventually move towards a world where we don't even have these status tabs and instead we'll use dropdowns (where you can select more than one status):

[luacmartins]

Cool, so which icons should I use for this one? Can you share the assets here please? I think we already have the checkmark one in app, but I couldn't find the checkbox one

[dannymcclain]

I think @dubielzyk-expensify is sick right now, but he's on it. ☑

[dubielzyk-expensify]

Here's the icon:

[luacmartins]

Thanks! PRs in review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.0-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add done status #56703

If no regressions arise, payment will be issued on 2025-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @thesahindia requires payment through NewDot Manual Requests