Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-27] [Navigation] Expense - App reopens confirm page when returning from confirm page using device gesture #56810

Closed
6 of 8 tasks
mitarachim opened this issue Feb 13, 2025 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Feb 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Money Requests

Action Performed:

Precondition:

  • Account has a default group workspace.
  1. Go to staging.new.expensify.com
  2. Open FAB > Create expense > Manual.
  3. Enter amount > Next.
  4. Click on the destination field.
  5. Select any user.
  6. On confirmation page, swipe to right (device back button on Android) to go back.
  7. Swipe to right (device back button on Android) to go back again.

Expected Result:

App will return to amount input page.

Actual Result:

When returning from recipient list, app opens confirmation page instead of amount input page.

This issue only happens when device back gesture is used instead of app back button.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6741420_1739414550384.ScreenRecording_02-13-2025_10-37-36_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @michaelkwardrop
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 13, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 13, 2025
@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 13, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot melvin-bot bot removed the Hourly KSv2 label Feb 13, 2025
@mountiny mountiny removed the DeployBlocker Indicates it should block deploying the API label Feb 13, 2025
@mountiny mountiny assigned mountiny and unassigned cristipaval Feb 13, 2025
@mountiny mountiny changed the title iOS - Expense - App reopens confirm page when returning from confirm page using device gesture [Navigation] iOS - Expense - App reopens confirm page when returning from confirm page using device gesture Feb 13, 2025
@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Feb 13, 2025
@mountiny
Copy link
Contributor

Demoting as it seems very minor. Its related to recent navigation changes and we will handle it with the SWM team as a follow up https://expensify.slack.com/archives/C01GTK53T8Q/p1739328522587109

@mountiny mountiny changed the title [Navigation] iOS - Expense - App reopens confirm page when returning from confirm page using device gesture [Navigation] Expense - App reopens confirm page when returning from confirm page using device gesture Feb 13, 2025
@SzymczakJ
Copy link
Contributor

I will take this one ✋

@michaelkwardrop
Copy link
Contributor

Great, assigning you @SzymczakJ

@michaelkwardrop
Copy link
Contributor

Do I need to add External and create a job in UpWork or is that unnecessary in this case?

@WojtekBoman
Copy link
Contributor

I think it's unnecessary as @SzymczakJ is working on it

Copy link

melvin-bot bot commented Feb 17, 2025

@mountiny, @SzymczakJ, @michaelkwardrop Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Feb 17, 2025
@SzymczakJ
Copy link
Contributor

Sorry I went on a sick leave on Friday, looking at this right now.

@melvin-bot melvin-bot bot removed the Overdue label Feb 17, 2025
@SzymczakJ
Copy link
Contributor

This will be fixed by #56876

@mountiny mountiny added the Reviewing Has a PR in review label Feb 17, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot changed the title [Navigation] Expense - App reopens confirm page when returning from confirm page using device gesture [Due for payment 2025-02-27] [Navigation] Expense - App reopens confirm page when returning from confirm page using device gesture Feb 20, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

  • @SzymczakJ does not require payment (Contractor)

Copy link

melvin-bot bot commented Feb 20, 2025

@mountiny @michaelkwardrop @SzymczakJ The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

No regression tests required and no payment required either this came from the big navigation update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants