Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per Diem - Imported Per Diem currency does not match the CSV used #56962

Closed
1 of 8 tasks
lanitochka17 opened this issue Feb 17, 2025 · 3 comments
Closed
1 of 8 tasks

Per Diem - Imported Per Diem currency does not match the CSV used #56962

lanitochka17 opened this issue Feb 17, 2025 · 3 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 17, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.99.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a Workspace
  3. Go to Workspace Settings
  4. Enable Per Diem via More Features
  5. Go to Per Diem and import a CSV containing two currencies for the same country (Use attached CSV)
  6. Complete importing Per Diem

Expected Result:

The imported per diem entries matches the country and currency pairs from the CSV

Actual Result:

The imported per diem entries for one of the countries uses USD on all entries even thought there should be only one USD entry in the CSV

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6745957_1739813447412.Recording__154.mp4

1_german_per_diem_-dependent_tags___2.csv

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 17, 2025
Copy link

melvin-bot bot commented Feb 17, 2025

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@ijmalik
Copy link
Contributor

ijmalik commented Feb 17, 2025

Hi @garrettmknight

Based on the CSV data:

Destination,Currency,Rate,Rate Amount
Afghanistan,USD,Full Day,30
Afghanistan,EUR,Part Day,20
Afghanistan,EUR,Overnight,95
Afghanistan,EUR,Breakfast,-6
Afghanistan,EUR,Lunch,-12
Afghanistan,EUR,Dinner,-12
...

System Behavior Observation:

The system assigns one currency per country, using the first entry’s currency (e.g., USD for Afghanistan).
Subsequent entries for the same country ignore their currency field (e.g., EUR rows for Afghanistan are overridden).
Changing the first entry’s currency (e.g., USD → EUR) updates the FE display for the entire country.

This appears intentional. Could you confirm this is the desired logic with the team?

Image

@garrettmknight
Copy link
Contributor

@ijmalik thanks for the note. Just reviewed and came to the same conclusion. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants