Expense - After payment cancellation, tapping pay elsewhere button is not responsive

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Go to workspace settings - create a workspace
3. Tap workflow and disable delay submissions and add approval
4. Tap workspace chat
5. Create an expense
6. Hold and uphold the expense
7. Pay the expense via pay elsewhere
8. Tap header - cancel the payment
9. Tap pay elsewhere in header

Expected Result:

After payment cancellation, tapping pay elsewhere button must be responsive

Actual Result:

After payment cancellation, tapping pay elsewhere button is not responsive.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6745977_1739814671835.Screenrecorder-2025-02-17-23-12-59-881.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• After payment cancellation, tapping pay elsewhere button is not responsive.

What is the root cause of that problem?

• The chatReportID can be empty in:

App/src/components/MoneyReportHeader.tsx

Line 109 in 06a370f

const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${moneyRequestReport?.chatReportID || CONST.DEFAULT_NUMBER_ID}`);

after canceling payment, so when clicking on pay elsewhere, the condition:

App/src/components/MoneyReportHeader.tsx

Line 223 in 06a370f

if (!type || !chatReport) {

is met.

What changes do you think we should make in order to solve the problem?

• Besides chatReportID, we can use parentReportID in:

App/src/components/MoneyReportHeader.tsx

Line 109 in 06a370f

const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${moneyRequestReport?.chatReportID || CONST.DEFAULT_NUMBER_ID}`);

    const [chatReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${moneyRequestReport?.chatReportID || moneyRequestReport?.parentReportID || CONST.DEFAULT_NUMBER_ID}`);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• UI bug, we don't need to test here.

What alternative solutions did you explore? (Optional)

[RachCHopkins]

Will triage on Monday. Needs a little setup.