Hybrid - Sign Up - Incorrect message displays when tap on "Join" button offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.1-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5617223&group_by=cases:section_id&group_order=asc&group_id=229043
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iOS Hybrid, Android Hybrid
App Component: Other

Action Performed:

Precondition: user should be SIgned Out

1. Open app
2. Tap on "Continue with email" button
3. Write an email, that was not been user before for registration
4. Disable internet connection
5. Tap on "Next" button
6. Enable internet connection and tap on "Next" button
7. Disable internet connection
8. Tap on "Join" button

Expected Result:

"Please check your internet connection message should be displayed when tapped on the "Join" button offline

Actual Result:

"Failed to create account - please try again with a different email or phone number." message displays when tapped on "Join" button offline

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6747728_1739961702942.ScreenRecording_02-19-2025_12-38-55_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hybrid - Sign Up - Incorrect message displays when tap on "Join" button offline

What is the root cause of that problem?

In

https://github.com/Expensify/Mobile-Expensify/blob/0170145859e44bc5e691f2d95fe6e181cefaf855/app/Controllers/AuthenticationController.js#L664

When the user is offline, we throw errorCode 5555 in response

{"jsonCode":5555,"message":"Request failed in _sendPost"}

But we expect blank response object wrongly.

This caused default error message to show up.

What changes do you think we should make in order to solve the problem?

In

https://github.com/Expensify/Mobile-Expensify/blob/0170145859e44bc5e691f2d95fe6e181cefaf855/app/Controllers/AuthenticationController.js#L664

Add

if (errorCode === 0 || errorCode === API.ERROR_WITH_MESSAGE) {
    yaplShowGrowl(UIStrings.CHECK_INTERNET_CONNECTION);
    return;
}

Result

Screen.Recording.2025-02-19.at.6.41.13.PM.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA since this is related to HybridApp

What alternative solutions did you explore? (Optional)