From d82a4a1655b98a0a31505052ff4037593ce7f853 Mon Sep 17 00:00:00 2001
From: Jan Kollars <kollars.jan@gmail.com>
Date: Thu, 2 Jul 2020 12:12:52 +0200
Subject: [PATCH 1/5] fix printing of list decoration in Firefox

---
 src/assets/styles/print/_index.scss | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/assets/styles/print/_index.scss b/src/assets/styles/print/_index.scss
index 396a8ed..94865aa 100644
--- a/src/assets/styles/print/_index.scss
+++ b/src/assets/styles/print/_index.scss
@@ -77,6 +77,7 @@
     .entrylist::before,
     .entrylist__item::before,
     .bulletlist li::before {
+        color-adjust: exact !important;
         -webkit-print-color-adjust: exact !important;
     }
 

From 6a73e3bf4d85e2eb9acb2fc5b271b2a3a2bce1e2 Mon Sep 17 00:00:00 2001
From: Jan Kollars <kollars.jan@gmail.com>
Date: Thu, 2 Jul 2020 18:05:26 +0200
Subject: [PATCH 2/5] only wrap halfwidth sections in grid container

this avoids page breaks inside of sections when printing (closes #6)
---
 src/assets/styles/components/_section.scss |  2 +
 src/includes/vcard.njk                     |  2 +-
 src/layouts/resume.njk                     | 44 +++++++++++-----------
 3 files changed, 26 insertions(+), 22 deletions(-)

diff --git a/src/assets/styles/components/_section.scss b/src/assets/styles/components/_section.scss
index e80270f..53b3c31 100644
--- a/src/assets/styles/components/_section.scss
+++ b/src/assets/styles/components/_section.scss
@@ -2,12 +2,14 @@
     display: grid;
     grid-template-columns: 1fr 1fr;
     column-gap: $spacing-x * 2;
+    page-break-inside: avoid;
 }
 
 .section {
     grid-column: span 2;
     padding-top: $spacing-y;
     padding-bottom: $spacing-y;
+    page-break-inside: avoid;
 
     @include mq(md, true) {
         &--half {
diff --git a/src/includes/vcard.njk b/src/includes/vcard.njk
index 3f3681b..20d8e72 100644
--- a/src/includes/vcard.njk
+++ b/src/includes/vcard.njk
@@ -47,7 +47,7 @@
                             {%- set isSocialIcon = true -%}
                             {%- icon social.name, isSocialIcon -%}
                             <span class="p-nickname">{{- social.user -}}</span>
-                            <span class="sr-only">on {{ social.name }}</a>
+                            <span class="sr-only">on {{ social.name }}</span>
                         </a>
                     {% endfor %}
                 </div>
diff --git a/src/layouts/resume.njk b/src/layouts/resume.njk
index 6ec7838..a8e0354 100644
--- a/src/layouts/resume.njk
+++ b/src/layouts/resume.njk
@@ -2,30 +2,31 @@
 layout: base
 ---
 
-<main class="main">
-    <div class="sections container">
+<main class="main container">
 
-        <section class="section" id="section-introduction">
-            <h2 class="section__title">About Me</h2>
-            <div class="lead p-summary" data-spellcheck>
-                {{ content | safe }}
-            </div>
-        </section>
+    <section class="section" id="section-introduction">
+        <h2 class="section__title">About Me</h2>
+        <div class="lead p-summary" data-spellcheck>
+            {{ content | safe }}
+        </div>
+    </section>
 
-        <section class="section" id="section-experience">
-            <h2 class="section__title">Work Experience</h2>
-            {% set entries = collections.work %}
-            {% set microformat = "p-experience" %}
-            {% include "entrylist.njk" %}
-        </section>
+    <section class="section" id="section-experience">
+        <h2 class="section__title">Work Experience</h2>
+        {% set entries = collections.work %}
+        {% set microformat = "p-experience" %}
+        {% include "entrylist.njk" %}
+    </section>
 
-        <section class="section" id="section-education">
-            <h2 class="section__title">Education</h2>
-            {% set entries = collections.education %}
-            {% set microformat = "p-education" %}
-            {% include "entrylist.njk" %}
-        </section>
+    <section class="section" id="section-education">
+        <h2 class="section__title">Education</h2>
+        {% set entries = collections.education %}
+        {% set microformat = "p-education" %}
+        {% include "entrylist.njk" %}
+    </section>
 
+    {% if author.skills or author.languages %}
+    <div class="sections">
         {% if author.skills %}
         <section class="section section--half" id="section-skills">
             <h2 class="section__title">Skills</h2>
@@ -47,6 +48,7 @@ layout: base
             </ul>
         </section>
         {% endif %}
-
     </div>
+    {% endif %}
+
 </main>
\ No newline at end of file

From b2339187ae3b6f694e43f70c9c17156e652562cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20B=C3=B6ck?= <hello@mxb.at>
Date: Thu, 9 Jul 2020 20:04:59 +0200
Subject: [PATCH 3/5] extract hardcoded strings to data file, #4

---
 src/assets/styles/base/_layout.scss        | 10 ++++++
 src/assets/styles/components/_section.scss | 24 ++++++-------
 src/data/strings.json                      | 15 ++++++++
 src/includes/footer.njk                    |  2 +-
 src/includes/sidebar.njk                   |  6 ++--
 src/layouts/resume.njk                     | 42 +++++++++++-----------
 6 files changed, 60 insertions(+), 39 deletions(-)
 create mode 100644 src/data/strings.json

diff --git a/src/assets/styles/base/_layout.scss b/src/assets/styles/base/_layout.scss
index 22c4640..fdaf4d8 100755
--- a/src/assets/styles/base/_layout.scss
+++ b/src/assets/styles/base/_layout.scss
@@ -48,3 +48,13 @@ body {
         padding-right: 7%;
     }
 }
+
+.grid {
+    display: grid;
+    column-gap: $spacing-x * 2;
+    page-break-inside: avoid;
+
+    &--2col {
+        grid-template-columns: 1fr 1fr;
+    }
+}
diff --git a/src/assets/styles/components/_section.scss b/src/assets/styles/components/_section.scss
index 53b3c31..acc6a6d 100644
--- a/src/assets/styles/components/_section.scss
+++ b/src/assets/styles/components/_section.scss
@@ -1,25 +1,21 @@
-.sections {
-    display: grid;
-    grid-template-columns: 1fr 1fr;
-    column-gap: $spacing-x * 2;
-    page-break-inside: avoid;
-}
-
 .section {
-    grid-column: span 2;
     padding-top: $spacing-y;
     padding-bottom: $spacing-y;
     page-break-inside: avoid;
 
-    @include mq(md, true) {
-        &--half {
-            grid-column: span 1;
-        }
-    }
-
     &__title {
         margin-bottom: $spacing-y;
         padding-bottom: 0.5rem;
         border-bottom: 1px solid $gray;
     }
 }
+
+.grid .section {
+    grid-column: span 2;
+
+    @include mq(md, true) {
+        &--half {
+            grid-column: span 1;
+        }
+    }
+}
diff --git a/src/data/strings.json b/src/data/strings.json
new file mode 100644
index 0000000..33abfc7
--- /dev/null
+++ b/src/data/strings.json
@@ -0,0 +1,15 @@
+{
+    "titles": {
+        "introduction": "About Me",
+        "experience": "Work Experience",
+        "education": "Education",
+        "skills": "Skills",
+        "languages": "Languages"
+    },
+    "labels": {
+        "email": "Email",
+        "telephone": "Telephone",
+        "print": "Print Résumé",
+        "lastUpdated": "Last updated"
+    }
+}
\ No newline at end of file
diff --git a/src/includes/footer.njk b/src/includes/footer.njk
index 8576568..cc9e4c5 100644
--- a/src/includes/footer.njk
+++ b/src/includes/footer.njk
@@ -1,7 +1,7 @@
 <footer class="footer">
     <div class="container utl-space-between">
         <p>&copy; {{ author.name }}</p>
-        <p>Last updated: {{ build.timestamp | dateToFormat('dd.MM.yyyy') }}</p>
+        <p>{{ strings.labels.lastUpdated }}: {{ build.timestamp | dateToFormat('dd.MM.yyyy') }}</p>
         {% if build.demo %}
             <a href="https://github.com/maxboeck/resume" class="repo-link utl-screen-only">
                 <span>{% icon "github" %} view source</span>
diff --git a/src/includes/sidebar.njk b/src/includes/sidebar.njk
index 9bd6e58..c495eb3 100644
--- a/src/includes/sidebar.njk
+++ b/src/includes/sidebar.njk
@@ -3,16 +3,16 @@
 
         <div class="actions">
             {% if author.email %}
-                <a class="actions__btn has-tooltip" aria-label="Email" href="mailto:{{ author.email | obfuscate | safe }}">
+                <a class="actions__btn has-tooltip" aria-label="{{ strings.labels.email }}" href="mailto:{{ author.email | obfuscate | safe }}">
                     {% icon "email" %}
                 </a>
             {% endif %}
             {% if author.telephone %}
-                <a class="actions__btn has-tooltip" aria-label="Telephone" href="tel:{{ author.telephone | stripSpaces }}">
+                <a class="actions__btn has-tooltip" aria-label="{{ strings.labels.telephone }}" href="tel:{{ author.telephone | stripSpaces }}">
                     {% icon "telephone" %}
                 </a>
             {% endif %}
-            <button class="actions__btn js-print utl-screen-only has-tooltip" aria-label="Print Résumé">
+            <button class="actions__btn js-print utl-screen-only has-tooltip" aria-label="{{ strings.labels.print }}">
                 {% icon "print" %}
             </button>
         </div>
diff --git a/src/layouts/resume.njk b/src/layouts/resume.njk
index a8e0354..e828935 100644
--- a/src/layouts/resume.njk
+++ b/src/layouts/resume.njk
@@ -4,32 +4,32 @@ layout: base
 
 <main class="main container">
 
-    <section class="section" id="section-introduction">
-        <h2 class="section__title">About Me</h2>
-        <div class="lead p-summary" data-spellcheck>
-            {{ content | safe }}
-        </div>
-    </section>
+        <section class="section" id="section-introduction">
+            <h2 class="section__title">{{ strings.titles.introduction }}</h2>
+            <div class="lead p-summary" data-spellcheck>
+                {{ content | safe }}
+            </div>
+        </section>
 
-    <section class="section" id="section-experience">
-        <h2 class="section__title">Work Experience</h2>
-        {% set entries = collections.work %}
-        {% set microformat = "p-experience" %}
-        {% include "entrylist.njk" %}
-    </section>
+        <section class="section" id="section-experience">
+            <h2 class="section__title">{{ strings.titles.experience }}</h2>
+            {% set entries = collections.work %}
+            {% set microformat = "p-experience" %}
+            {% include "entrylist.njk" %}
+        </section>
 
-    <section class="section" id="section-education">
-        <h2 class="section__title">Education</h2>
-        {% set entries = collections.education %}
-        {% set microformat = "p-education" %}
-        {% include "entrylist.njk" %}
-    </section>
+        <section class="section" id="section-education">
+            <h2 class="section__title">{{ strings.titles.education }}</h2>
+            {% set entries = collections.education %}
+            {% set microformat = "p-education" %}
+            {% include "entrylist.njk" %}
+        </section>
 
     {% if author.skills or author.languages %}
-    <div class="sections">
+    <div class="grid grid--2col">
         {% if author.skills %}
         <section class="section section--half" id="section-skills">
-            <h2 class="section__title">Skills</h2>
+            <h2 class="section__title">{{ strings.titles.skills }}</h2>
             <ul class="bulletlist">
             {% for skill in author.skills %}
                 <li class="p-skill">{{ skill }}</li>
@@ -40,7 +40,7 @@ layout: base
 
         {% if author.languages %}
         <section class="section section--half" id="section-languages">
-            <h2 class="section__title">Languages</h2>
+            <h2 class="section__title">{{ strings.titles.languages }}</h2>
             <ul class="bulletlist">
             {% for language in author.languages %}
                 <li class="p-skill">{{ language.name }} ({{ language.level }})</li>

From 15479c6bf2c2f45535018a46899cfb736c856a78 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20B=C3=B6ck?= <hello@mxb.at>
Date: Thu, 9 Jul 2020 20:15:13 +0200
Subject: [PATCH 4/5] add "present" to translateable strings, #4

---
 src/data/strings.json  | 1 +
 src/includes/entry.njk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/data/strings.json b/src/data/strings.json
index 33abfc7..6531f6e 100644
--- a/src/data/strings.json
+++ b/src/data/strings.json
@@ -10,6 +10,7 @@
         "email": "Email",
         "telephone": "Telephone",
         "print": "Print Résumé",
+        "present": "Present",
         "lastUpdated": "Last updated"
     }
 }
\ No newline at end of file
diff --git a/src/includes/entry.njk b/src/includes/entry.njk
index 1aea807..1a5e66c 100644
--- a/src/includes/entry.njk
+++ b/src/includes/entry.njk
@@ -12,7 +12,7 @@
                     {{ entry.data.end | dateToFormat("MM/yyyy") }}
                 </time>
             {% else %}
-                <span>Present</span>
+                <span>{{ strings.labels.present }}</span>
             {% endif %}
         </p>
 

From 67567fac5a0708945a2bfde285e95f6dde35d164 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20B=C3=B6ck?= <hello@mxb.at>
Date: Thu, 9 Jul 2020 20:17:53 +0200
Subject: [PATCH 5/5] update readme, #4

---
 README.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/README.md b/README.md
index 771dc61..c4b46d3 100644
--- a/README.md
+++ b/README.md
@@ -206,6 +206,10 @@ Supported properties are:
     </tbody>
 </table>
 
+## 5. Internationalization
+
+There are a few hardcoded english strings used in the template, such as the section titles and some labels. If you want to change the default language from english to something else, you can translate these strings by changing the values in `data/strings.json`.
+
 ## SpellCheck
 
 If you run the project locally in development, the content of your `introduction` and `entries` will be automatically spell-checked using your system default spellcheck engine.