Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Refine debouncing configuration #52

Open
FeralAI opened this issue Jan 25, 2022 · 1 comment
Open

Refine debouncing configuration #52

FeralAI opened this issue Jan 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@FeralAI
Copy link
Owner

FeralAI commented Jan 25, 2022

Debouncing is currently configured at the beginning of the main.cpp file with a fixed 5ms delay. At the very least this should be editable via the web configurator.

A more robust implementation would have preset values for certain types of devices. For instance stock Sanwa JLFs may need more than the stock 5ms debounce delay, but the normal buttons may not. Would be nice to say "set debounce to X for directionals/stick and Y for buttons".

@FeralAI FeralAI added the enhancement New feature or request label Jan 25, 2022
@jbarket
Copy link
Collaborator

jbarket commented Apr 17, 2022

This should definitely be part of the button redo.

To me it seems like physical buttons.. pins… whatever correspond with something button wise, and there’s where LEDs and denounce belong.

For example, if someone made a controller that has both buttons and a stick for movement, debounce values might be different for the stick direction than the button direction

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants