Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateOnSave in the doc but not in the code #130

Open
fakocher opened this issue Oct 2, 2019 · 3 comments
Open

validateOnSave in the doc but not in the code #130

fakocher opened this issue Oct 2, 2019 · 3 comments

Comments

@fakocher
Copy link
Contributor

fakocher commented Oct 2, 2019

Hello everyone!

I'd like to know why validateOnSave is in the doc but not in the source code. Will it be released soon?

Note that I would gladly code it if you need.

Thanks for your answer,
Best Regards,
Jeremy

@rajeev-ayer
Copy link

Any progress on this issue?

I came across this issue when attempting to set validateOnSave to false due to the recursive validation always validating to false and therefore never executing the save transaction. The validateOnSave setting is never actually referenced in the code and therefore always validates regardless of what value the option is set to.

Will this be fixed anytime soon?

@rtheunissen
Copy link
Collaborator

rtheunissen commented May 24, 2021

Will this be fixed anytime soon?

I will fix this this week and release a new version with whatever else is on main.

due to the recursive validation always validating to false

Is this a known issue? #168

I'll take a look at that too.

@rajeev-ayer
Copy link

That would be fantastic @rtheunissen. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants