Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Bower at top level #183

Open
i-like-robots opened this issue Sep 25, 2018 · 3 comments
Open

Install Bower at top level #183

i-like-robots opened this issue Sep 25, 2018 · 3 comments
Labels
housekeeping Cleaning things up not that we want to encourage this sort of thing behaviour we could implement but we'd rather people didn't use question Further information is requested

Comments

@i-like-robots
Copy link
Contributor

Bower may only need to be installed once at the top-level because it supports a cwd config option, e.g.:

bower i sass-mq --config.cwd=components/x-teaser

We could therefore refactor to run bower install using athloi in future.
@i-like-robots i-like-robots added question Further information is requested housekeeping Cleaning things up labels Sep 25, 2018
@apaleslimghost
Copy link
Member

previously we've avoided doing this because it makes it look like a first-class officially-sanctioned thing but we'd rather people not be using bower, and once origami isn't using it any more we should kill it, wdyt

@i-like-robots
Copy link
Contributor Author

Oh yeah, I should have signed off the issue "Not that we want to encourage this sort of thing"

@apaleslimghost apaleslimghost added the not that we want to encourage this sort of thing behaviour we could implement but we'd rather people didn't use label Sep 25, 2018
@i-like-robots
Copy link
Contributor Author

We have done this as a part of Anvil Financial-Times/dotcom-page-kit#113

@apaleslimghost apaleslimghost mentioned this issue Dec 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
housekeeping Cleaning things up not that we want to encourage this sort of thing behaviour we could implement but we'd rather people didn't use question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@i-like-robots @apaleslimghost