Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a precommit hook to prevent package-lock.json files being committed #329

Open
apaleslimghost opened this issue Jun 6, 2019 · 1 comment
Open

use a precommit hook to prevent package-lock.json files being committed #329

apaleslimghost opened this issue Jun 6, 2019 · 1 comment
Labels
enhancement New feature or request housekeeping Cleaning things up

Comments

@apaleslimghost
Copy link
Member

despite our .npmrc and make install --no-package-lock configurations, these files keep cropping up and causing build problems. we should add a pre-commit hook to remove these files from any commit (with a warning).
@apaleslimghost apaleslimghost added enhancement New feature or request housekeeping Cleaning things up labels Jun 6, 2019
@i-like-robots
Copy link
Contributor

I removed package-lock.json from the .gitignore config when we tried to use them last year to speed up install times. i've re-added it in #339.

@i-like-robots i-like-robots mentioned this issue Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request housekeeping Cleaning things up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add package-lock.json files to .gitignore configuration Financial-Times/x-dash
2 participants
@i-like-robots @apaleslimghost