Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Don't require .env file for deploying to production #159

Open
lfcipriani opened this issue Aug 7, 2018 · 1 comment
Open

Don't require .env file for deploying to production #159

lfcipriani opened this issue Aug 7, 2018 · 1 comment

Comments

@lfcipriani
Copy link

While deploying using docker to Heroku, I realized that we always need the .env file copied to the image otherwise the node app will throw an exception that it's missing. This means also that the node app don't take into account the envitonment variable set by Heroku.

It's not safe to create docker image with .env containing secrets. Would be nice to be able to disable dotenv support in production and rely on real environment variables.

Thanks

@joeellis
Copy link

Also running into this - it'd be nice to just defer to process.env if the .env file is not there and not require the file be there. Also comes up when deploying directly from a git repo, which wouldn't have the .env file in it (since it shouldn't be committed).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants