Skip to content

Commit 41865d8

Browse files
neginraooffacebook-github-bot
authored andcommitted
[ONNX] Update black_listed_operators for opset 12 (pytorch#39414)
Summary: Remove black_listed_operators for opset 12 as we now support these ops. Pull Request resolved: pytorch#39414 Reviewed By: hl475 Differential Revision: D21915584 Pulled By: houseroad fbshipit-source-id: 37ec7bdd2b5a845484535054026d6613d0921b7a
1 parent 65f67bb commit 41865d8

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

test/onnx/test_pytorch_onnx_onnxruntime.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3623,10 +3623,6 @@ def setup_rnn_tests():
36233623
('lstm', 'lstm', {}),
36243624
('gru', 'gru', {})
36253625
):
3626-
# This is a hack to skip elman_rnn bidirectional tests for now
3627-
# TODO: Revert this once elman_rnn bidirectional issue is fixed
3628-
if base == 'elman' and bidirectional[1] == 'bidirectional':
3629-
continue
36303626
make_test(name, base, layer, bidirectional, initial_state,
36313627
variable_length, dropout,
36323628
**extra_kwargs)
@@ -3637,10 +3633,8 @@ def setup_rnn_tests():
36373633

36383634
# make sure no one accidentally disables all the tests without
36393635
# noticing
3640-
# assert test_count == 192, test_count
3641-
# TODO: Revert this once elman_rnn bidirectional issue is fixed
3642-
if test_count != 144:
3643-
raise ValueError('Expected 144 tests but found {}'.format(test_count))
3636+
if test_count != 192:
3637+
raise ValueError('Expected 192 tests but found {}'.format(test_count))
36443638

36453639

36463640
setup_rnn_tests()

torch/onnx/symbolic_opset12.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@
1010

1111
# This file exports ONNX ops for opset 12
1212

13-
black_listed_operators = [
14-
"ArgMin", "ArgMax"
15-
]
16-
1713
@parse_args('s', 'v')
1814
def einsum(g, equation, tensor_list):
1915
tensors = sym_help._unpack_list(tensor_list)

0 commit comments

Comments
 (0)